Cache connection config in the HTTP/1, HTTP/2 and HTTP/3 loop records#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Finishes hoisting connection-stable config out of the per-request and per-stream hot paths into the connection loop records, so the steady state pattern-matches cached fields instead of re-reading
proto_optsevery time. Covers HTTP/1 (request/keep-alive timeouts, body buffering,hibernate_after,alt_svc), HTTP/2 (hibernate_after,alt_svc, request-slot counters), and HTTP/3 (request-slot counters);roadrunner_http:auto_headers/2and theroadrunner_connrequest-slot helpers now take the resolved values directly.This is a consistency change, not a measurable throughput win: the reads it removes are O(1) map probes already in the preferred pattern-match idiom, so any delta sits inside bench variance.