Skip to content

feat: add support for partitions in the arn - #40

Merged
aripalo merged 3 commits into
aripalo:mainfrom
karolyp:feat/support-partitions
Sep 23, 2026
Merged

aripalo merged 3 commits into
aripalo:mainfrom
karolyp:feat/support-partitions

Conversation

@karolyp

@karolyp karolyp commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Fixes #39

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blimmer

blimmer commented Jan 25, 2025

Copy link
Copy Markdown

@karolyp - I decided to create my own replacement construct for this library: https://github.com/blimmer/cdk-github-oidc. It fixes this issue and all other outstanding issues for this repo. Feel free to migrate to use @blimmer/cdk-github-oidc instead.

@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6302262) to head (73ea9ac).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          312       312           
  Branches        14        14           
=========================================
  Hits           312       312           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aripalo
aripalo merged commit 6f10231 into aripalo:main Sep 23, 2026
10 of 11 checks passed
@aripalo

aripalo commented Sep 23, 2026

Copy link
Copy Markdown
Owner

@karolyp: Sorry this took ages, but I guess "better late than never"? 😅

Thanks a lot for the contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: support partitions

3 participants