Skip to content

testrunner: show text-calldata comment on failing dispatch tests #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbenke merged 4 commits into from
Jun 19, 2026
Merged

testrunner: show text-calldata comment on failing dispatch tests #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92b5a26
testrunner: show text-calldata on failing dispatch tests
claude Jun 16, 2026
8d77a0c
testrunner: rename test input field text-calldata to comment
claude Jun 18, 2026
175b7fd
Merge remote-tracking branch 'origin/main' into testrunner-text
mbenke Jun 19, 2026
9174fc7
change remaining text-calldata to comment
mbenke Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/examples/dispatch/Revert.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@
"tests": [
{
"input": {
"comment": "constructor()",
"calldata": "",
"value": "0"
},
"kind": "constructor"
},
{
"input": {
"text-calldata": "noAnswer()",
"comment": "noAnswer()",
"calldata": "08ad856f",
"value": "0"
},
Expand All @@ -24,7 +25,7 @@
},
{
"input": {
"text-calldata": "answer()(uint256)",
"comment": "answer()(uint256)",
"calldata": "85bb7d69",
"value": "0"
},
Expand Down
77 changes: 39 additions & 38 deletions test/examples/dispatch/basic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@
"tests": [
{
"input": {
"comment": "constructor()",
"calldata": "",
"value": "0"
},
"kind": "constructor"
},
{
"input": {
"text-calldata": "nothing()",
"comment": "nothing()",
"calldata": "448f30a3",
"value": "0"
},
Expand All @@ -24,7 +25,7 @@
},
{
"input": {
"text-calldata": "something()(uint256)",
"comment": "something()(uint256)",
"calldata": "a7a0d537",
"value": "0"
},
Expand All @@ -36,7 +37,7 @@
},
{
"input": {
"text-calldata": "add2(uint256,uint256)(uint256) 2 3",
"comment": "add2(uint256,uint256)(uint256) 2 3",
"calldata": "0x29fcda3300000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000003",
"value": "0"
},
Expand All @@ -48,7 +49,7 @@
},
{
"input": {
"text-calldata": "add3(uint256,uint256,uint256)(uint256) 2 3 4",
"comment": "add3(uint256,uint256,uint256)(uint256) 2 3 4",
"calldata": "0x3faee853000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000030000000000000000000000000000000000000000000000000000000000000004",
"value": "0"
},
Expand All @@ -60,19 +61,19 @@
},
{
"input": {
"text-calldata": "id_bytes32(bytes32) -> (bytes32)",
"calldata":"0x10a4b2d4deadbeefcafebabe000000000000000000000000000000000000000000000000",
"comment": "id_bytes32(bytes32) -> (bytes32)",
"calldata": "0x10a4b2d4deadbeefcafebabe000000000000000000000000000000000000000000000000",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"deadbeefcafebabe000000000000000000000000000000000000000000000000",
"returndata": "deadbeefcafebabe000000000000000000000000000000000000000000000000",
"status": "success"
}
},
{
"input": {
"text-calldata": "id_pair()(uint256,uint256)",
"comment": "id_pair()(uint256,uint256)",
"calldata": "5880a1a0",
"value": "0"
},
Expand All @@ -84,121 +85,121 @@
},
{
"input": {
"text-calldata": "id_bytes(bytes) -> (bytes)",
"calldata":"0xbb1ec80900000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"comment": "id_bytes(bytes) -> (bytes)",
"calldata": "0xbb1ec80900000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"returndata": "00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"status": "success"
}
},
{
"input": {
"text-calldata": "id_string(string) -> (string)",
"calldata":"0x145ef75500000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"comment": "id_string(string) -> (string)",
"calldata": "0x145ef75500000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"returndata": "00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004deadbeef00000000000000000000000000000000000000000000000000000000",
"status": "success"
}
},
{
"input": {
"text-calldata": "id_bytes(bytes) with offset but no length/content (head OK, tail truncated)",
"calldata":"0xbb1ec8090000000000000000000000000000000000000000000000000000000000000020",
"comment": "id_bytes(bytes) with offset but no length/content (head OK, tail truncated)",
"calldata": "0xbb1ec8090000000000000000000000000000000000000000000000000000000000000020",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000",
"returndata": "00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000",
"status": "success"
}
},
{
"input": {
"text-calldata": "id_string(string) with offset+length=4 but content truncated",
"calldata":"0x145ef75500000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004",
"comment": "id_string(string) with offset+length=4 but content truncated",
"calldata": "0x145ef75500000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000",
"returndata": "000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000",
"status": "success"
}
},
{
"input": {
"text-calldata": "selector too short (same error as missing fallback)",
"calldata":"c0de",
"comment": "selector too short (same error as missing fallback)",
"calldata": "c0de",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"4924aef0",
"returndata": "4924aef0",
"status": "failure"
}
},
{
"input": {
"text-calldata": "empty calldata (cdsz == 0) -- the 'plain ETH transfer' shape",
"calldata":"",
"comment": "empty calldata (cdsz == 0) -- the 'plain ETH transfer' shape",
"calldata": "",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"4924aef0",
"returndata": "4924aef0",
"status": "failure"
}
},
{
"input": {
"text-calldata": "abi data too short -- using id_string(string)",
"calldata":"145ef755",
"comment": "abi data too short -- using id_string(string)",
"calldata": "145ef755",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"08638556",
"returndata": "08638556",
"status": "failure"
}
},
{
"input": {
"text-calldata": "value sent for non-payable function",
"calldata":"a7a0d537",
"comment": "value sent for non-payable function",
"calldata": "a7a0d537",
"value": "42"
},
"kind": "call",
"output": {
"returndata":"b5988ea3",
"returndata": "b5988ea3",
"status": "failure"
}
},
{
"input": {
"text-calldata": "missing fallback",
"calldata":"deadc0de",
"comment": "missing fallback",
"calldata": "deadc0de",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"4924aef0",
"returndata": "4924aef0",
"status": "failure"
}
},
{
"input": {
"text-calldata": "non-public hidden() must not be dispatched",
"calldata":"aef6d4b1",
"comment": "non-public hidden() must not be dispatched",
"calldata": "aef6d4b1",
"value": "0"
},
"kind": "call",
"output": {
"returndata":"4924aef0",
"returndata": "4924aef0",
"status": "failure"
}
}
Expand Down
Loading
Loading