Improve diagnostics#416
Open
Y-Nak wants to merge 36 commits into
Open
Conversation
mbenke
reviewed
May 27, 2026
mbenke
left a comment
Collaborator
There was a problem hiding this comment.
In some cases the error message is repeated, e.g.
$ esolc tmp/unsafeFromWord.solc
tmp/unsafeFromWord.solc
error: module typecheck failed for /home/ben/work/review/tmp/unsafeFromWord.solc (no desugaring):
Type not polymorphic enough! The annotated type is:
forall a . word -> a
but the infered type is:
word -> word
in:
forall a . function fromWord (x : word) -> a
- in:forall a . function fromWord (x : word) -> a {
let result ;
assembly {
result := x
}
return result;
}
──> /home/ben/work/review/tmp/unsafeFromWord.solc:3:30
│
3 │ assembly { result := x }
│ ^ module typecheck failed for /home/ben/work/review/tmp/unsafeFromWord.solc (no desugaring):
Type not polymorphic enough! The annotated type is:
forall a . word -> a
but the infered type is:
word -> word
in:
forall a . function fromWord (x : word) -> a
- in:forall a . function fromWord (x : word) -> a {
let result ;
assembly {
result := x
}
return result;
}
rodrigogribeiro
approved these changes
May 28, 2026
rodrigogribeiro
left a comment
Collaborator
There was a problem hiding this comment.
The previous comment on the codes used is not a blocker: I just want to understand the logic behind the choice for the codes.
Great work!
| (moduleReferenceHelp code) | ||
|
|
||
| moduleReferenceLabelMessage :: String -> String -> String | ||
| moduleReferenceLabelMessage "SC0118" _ = "external library import" |
Collaborator
There was a problem hiding this comment.
Could this be an enumeration instead of a String?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve compiler diagnostics.
This PR adds structured diagnostics and source spans in more places, so errors can show file, line, column and labels.
Remaining things that should be addressed later are:
tcmError/SC0299errors are still there