Add scatterplots in-terminal to the comparison#10
Open
msooseth wants to merge 6 commits into
Open
Conversation
In cross-version mode, `compare` now draws a comparison scatter: one dot per benchmark, x = baseline cpu_time, y = target cpu_time, with the y=x diagonal. Dots on the line are unchanged; below it the target is faster. The plot is rendered with gnuplot and always saved to solc-bench-compare.png so it can be reused. When stdout is a terminal that speaks the kitty graphics protocol or sixel (detected by querying the terminal), it is also drawn inline. gnuplot's kitty/sixel terminals home the cursor and clear the screen, so those escapes are stripped to keep the image flowing inline below the table. gnuplot is bundled onto the wrapped binary's PATH via the Nix flake. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The compare command now draws baseline-vs-target scatters for cpu_time, cycles, and peak_rss instead of cpu_time alone. Each panel is a square 384x384 plot (down from 640x640), saved as compare_<metric>.png, and the panels render side by side inline via gnuplot multiplot. Each dot is one benchmark, pairing the baseline and target medians. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Trim the verbose comments and docstrings to the essentials; no behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They make more sense now that we have more things being compiled.
Also removing the printing to the millionth of a second and nonsense like that. We can't measure to that precision with any reliability. I am reducing precision printed to 1/100th of a second. Noise level is way higher than that. Same with memory, reducing to 0.01MB precision, nobody cares about anything more.