Add thapi_start() and thapi_stop()#454
Open
thilinarmtb wants to merge 45 commits intoargonne-lcf:develfrom
Open
Add thapi_start() and thapi_stop()#454thilinarmtb wants to merge 45 commits intoargonne-lcf:develfrom
thapi_start() and thapi_stop()#454thilinarmtb wants to merge 45 commits intoargonne-lcf:develfrom
Conversation
3 tasks
8120018 to
7a184b7
Compare
19954ee to
9817061
Compare
Contributor
Author
|
@TApplencourt : Two tests fail out of the three tests used to check the toggle API. Those two fail |
Collaborator
|
I can show you how to do it tomorrow : ) |
Contributor
Author
Works for me. |
c03a7f1 to
1e2e22b
Compare
This is done by adding `__attribute((constructor))__` to `thapi_stop()`. Added an autotools check to see if the compiler supports `__attribute((constructor))__`.
and install `thapi_profiler.h` header files to provied declarations of `thapi_start()` and `thapi_stop()`.
1e2e22b to
7502384
Compare
7502384 to
889b0d5
Compare
889b0d5 to
7ae17f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created
lttng_ust_toggleevent category and implementedthapi_start()andthapi_stop()(in a similar spirit to
cudaProfilerStart()etc.). The library which the user has to link against isnamed
libThapi.so.Usage of the API is as follows:
If
libThapi.sois linked,thapi_stop()is called automatically during the library load time using__attribute__((constructor)). I added a check inconfigure.acto check if the compiler supports__attribute__((constructor)).P.S: This feature requires
lttng-ust >= 2.12.8. Specifically, this fix.TODO
Respectlttng_ust_profiler_*lttng_ust_toggle_*events when calculating statisticsfilter.toggle.toggletobabeltracegraph