Added the valve settings

[arghyabi]

No description provided.

[Copilot]

Pull Request Overview

This pull request adds valve control functionality to the irrigation system, allowing users to configure and control two valves through a web interface. The changes include automated valve operation at scheduled times (8 AM and 8 PM) with configurable durations.

• Adds web UI configuration dropdowns for valve durations (1-15 minutes)
• Implements backend logic for valve timing and automated scheduling
• Adds GPIO pin definitions and setup for two valve controls

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Web/script.js	Adds valve configuration UI functions and duplicate event listeners
Web/motor.php	Extends API to handle valve duration configuration requests
Web/index.html	Adds valve configuration dropdowns to the web interface
Scripts/PinDescription.py	Defines GPIO pin numbers for valve controls
Scripts/Main.py	Implements valve control logic with scheduled operations
Scripts/Common.py	Adds valve-related constants and timing configurations

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The cleanupGpio function only turns off MOTOR_PIN but doesn't turn off VALVE1_PIN and VALVE2_PIN. This could leave valves running after the program exits.

[Copilot]

[nitpick] The string manipulation to generate the selectedSpan ID is complex and error-prone. Consider using a mapping object or more explicit ID generation to improve readability.

Suggested change

	function updateConfigValue(id, value) {
	const select = document.getElementById(id);
	const selectedSpan = document.getElementById(`selected${id.charAt(0).toUpperCase() + id.slice(1)}`);
	if (value) {
	select.value = value;
	selectedSpan.textContent = `${value} min`;
	// Mapping from select element IDs to their corresponding span IDs
	const selectToSpanMap = {
	valve1Duration: 'selectedValve1Duration',
	valve2Duration: 'selectedValve2Duration'
	};
	function updateConfigValue(id, value) {
	const select = document.getElementById(id);
	const spanId = selectToSpanMap[id];
	const selectedSpan = document.getElementById(spanId);
	if (value) {
	select.value = value;
	if (selectedSpan) {
	selectedSpan.textContent = `${value} min`;
	}

[Copilot]

The valve scheduling logic only checks the hour but not minutes/seconds. This means valves could be activated multiple times within the same hour if the loop runs multiple times, despite the morningRunDone/eveningRunDone flags.

[Copilot]

The valve scheduling logic only checks the hour but not minutes/seconds. This means valves could be activated multiple times within the same hour if the loop runs multiple times, despite the morningRunDone/eveningRunDone flags.