Added Version control github action#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow to enforce version control requirements by ensuring that config.yaml and its appVersion field are updated in pull requests.
- Adds automated validation for version file updates
- Enforces that both the config file is modified and the appVersion field is changed
- Configured to run on pull request events (opened and synchronize)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| - name: Check if appVersion in config.yaml has been updated | ||
| run: | | ||
| VERSION_CHANGE=$(git diff HEAD^ HEAD config.yaml | grep 'appVersion') |
There was a problem hiding this comment.
The grep command will match any line containing 'appVersion', including comments or documentation. This could lead to false positives. Consider using a more specific pattern like grep '^[[:space:]]*appVersion:' to match only the actual configuration field.
Suggested change
| VERSION_CHANGE=$(git diff HEAD^ HEAD config.yaml | grep 'appVersion') | |
| VERSION_CHANGE=$(git diff HEAD^ HEAD config.yaml | grep '^[[:space:]]*appVersion:') |
Signed-off-by: Arghya Biswas <arghyabiswas05@gmail.com>
471c72d to
a55c188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.