Fix manual motor control on off#12
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors database write operations and fixes timing configurations for motor control operations. The changes improve efficiency by only writing to the database when there are actual changes and consolidate the write logic.
- Refactored
writeRtDbfunction to use**kwargsand only write when there are changes - Modified valve operation timing schedules
- Reduced check interval from 5 seconds to 0.5 seconds for more responsive monitoring
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Scripts/Utility.py | Simplified writeRtDb function to use kwargs and conditional writing |
| Scripts/Main.py | Updated timing logic, improved database update efficiency, and added debug logging |
| Scripts/Common.py | Reduced check interval for more frequent monitoring |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| waterLevel = TANK_HEIGHT - distance | ||
| motorStatus = rtDb.get("motorStatus", "OFF") | ||
| print(f"!!!! Motor Status {motorStatus}; Config Update Available: {configUpdateAvailable} !!!!") |
There was a problem hiding this comment.
This debug print statement with excessive exclamation marks appears to be temporary debugging code that should be removed or converted to proper logging before production.
Signed-off-by: Arghya Biswas <arghyabiswas05@gmail.com>
arghyabi
force-pushed
the
fix_manual_motor_control
branch
from
0381296 to
faa6710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.