Implement cluster rebalance rollback and cleanup#2251
Draft
whitehawk wants to merge 29 commits intofeature/ADBDEV-6608from
Draft
Implement cluster rebalance rollback and cleanup#2251whitehawk wants to merge 29 commits intofeature/ADBDEV-6608from
whitehawk wants to merge 29 commits intofeature/ADBDEV-6608from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement cluster rebalance rollback and cleanup
This patch adds:
tool execution (during both normal and rollback flows). Errored steps can be
retried, rolled back individually, or cancelled.
In order to facilitate the capabilities above:
via 'pg_ctl'.
fault injector, as now it is used not only with the state machine functions.
the statuses of the normal flow. Instead, 'rollback' flag is added to
distinguish between the steps of the normal and rollback flows.
coordinate cleanup and rollback between shrink and rebalance.
proper error handling is done by the rebalance execution engine itself.
'check_running_gputils()' (otherwise, in some test cases
'check_running_gputils()' fails when accessing the cluster).
option when moving mirrors, as, when retrying a failed operation, in some cases
there will be no old datadir yet, and 'gpmovemirrors' will fail at resource
estimation. So we skip resource estimation at 'gpmovemirrors' side. It is not a
problem, as we have our own resource estimation.
'3', as these cases are not checked in the newly added test cases differently.
tested with the help of fault injections in the 'gprecoverseg' at particular
points of interest.