This repository was archived by the owner on Jan 14, 2026. It is now read-only.
ADBDEV-8922: Restore global size limits for table_size_map and quota_info_map#53
Merged
ADBDEV-8922: Restore global size limits for table_size_map and quota_info_map#53
Conversation
RekGRpth
changed the title
dkovalev1
reviewed
Dec 16, 2025
dkovalev1
reviewed
Dec 17, 2025
dkovalev1
reviewed
Dec 18, 2025
RekGRpth
changed the title
dkovalev1
approved these changes
Dec 18, 2025
KnightMurloc
left a comment
KnightMurloc
left a comment
There was a problem hiding this comment.
Why can't we make tests for hash map overflow as was done in 2862042?
Member
Author
This patch doesn't fix any overflows! Furthermore, the tests from that commit also work with this patch! |
KnightMurloc
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore global size limits for table_size_map and quota_info_map
Commit 2862042 introduced a regression where the shared hash tables
table_size_map and quota_info_map could overflow. Their size was limited for
each database (worker) separately, while memory was requested for them only
once for the entire instance.
Commit 6ebff01 fixed this by requesting memory for each database (worker)
separately. Although this avoided overflow, it significantly increased the
consumption of shared memory.
Restore the original design, in which memory is requested only once for the
entire instance; each database (worker) has its own shared hash maps, but the
number of elements in them is limited by global atomic counters.
There are no tests because it is quite difficult to run out of shared memory
without exceeding the limit for each database.
Ticket: ADBDEV-8922