Repository navigation
Fix native-app OAuth callbacks with temporary ports - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes native-app sign-in when the app selects a temporary local callback port. Codex publishes
http://127.0.0.1/callbackbut connects using an available port, such ashttp://127.0.0.1:58043/callback.Apply the loopback port rule from RFC 8252 during authorization and token exchange. All other callback components must still match; token exchange remains tied to the exact callback chosen for that sign-in. Update the OAuth documentation to include Codex.
Evidence
redirect_uri not registered for this client.Merge Danger
Door: Two-way. No storage migration.
Blast Radius: Connections.
Changes callback matching for HTTP loopback addresses. Existing access tokens are unaffected.