Skip to content

NDPluginROIStat: return after rank guard to prevent heap OOB on 3-D (RGB) arrays #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkRivers merged 1 commit into from
Jul 16, 2026
Merged

NDPluginROIStat: return after rank guard to prevent heap OOB on 3-D (RGB) arrays #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ADApp/pluginSrc/NDPluginROIStat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,16 @@ void NDPluginROIStat::processCallbacks(NDArray *pArray)
/* Call the base class method */
NDPluginDriver::beginProcessCallbacks(pArray);

// This plugin only works with 1-D or 2-D arrays
// This plugin only works with 1-D or 2-D arrays. NDROI_t sizes offset[],
// size[] and arraySize[] to 2 elements, so a higher-rank array (e.g. any
// RGB1/2/3 colour frame, ndims==3) would drive the dim loop below past the
// end of those arrays. Bail out here instead of merely warning.
if ((pArray->ndims < 1) || (pArray->ndims > 2)) {
asynPrint(pasynUserSelf, ASYN_TRACE_ERROR,
"%s: error, number of array dimensions must be 1 or 2\n",
functionName);
delete[] pROIs;
return;
}

//Set NDArraySize params to the input pArray, because this plugin doesn't change them
Expand Down
Loading