云径寻舟，双窗同渡 · Resolve Windows npx in release builds - #56
Merged
Conversation
Resolve the platform-specific npx command shim before rebuilding the bundled PDFium addon. This keeps the release builder portable when Windows exposes npx as npx.cmd. Add a focused regression test that verifies the resolved shim is passed to the subprocess invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npxexecutable before rebuilding the bundled PDFium addonnpx.cmdshim exposed by Windows runnersRelease evidence
The unpublished
0.5.6dry-run 30535427156 passed registry validation and then failed on Windows x64 before compilation because Python could not launch the barenpxcommand. No npm package or dist-tag was published.Validation
python -m unittest tests.python.test_pdfium_renderer(3 tests)python -m unittest discover -s tests/python -p "test_*.py"(83 tests)git diff --check