Repository navigation
Clean up capture service, GUI, and decoder; add solution file - #2
Merged
Merged
Conversation
- Remove dead single-shot Capture() (superseded by CaptureAll, unused by the GUI) - Drop internal "Feature N" comments in MainForm in favor of plain descriptions - Extract the 60s listen window into a MainForm.ListenSeconds constant instead of repeating the literal across status strings and the CaptureAll call - Persist the selected adapter by its stable Npcap device name instead of its description, which can collide across identical NICs - Validate the CDP header checksum and surface the result as an informational RawTlvs entry, without rejecting frames with padding-affected checksums - Only print "Native VLAN" in LinkData.ToReport() when CDP supplied it, so LLDP neighbours (which carry VLAN info via PortVlanId instead) don't show a blank line - Add dotnet/LDWin.sln covering all three projects for local/IDE builds
archietownsend
marked this pull request as ready for review
July 9, 2026 09:05
archietownsend
added a commit
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A round of small, low-risk improvements identified from a full read-through of the codebase:
CaptureService.Capture()(single-neighbour capture) was superseded byCaptureAll()and no longer called anywhere in the app, but the ~80-line implementation and interface member remained, duplicating the open/filter/loop/close logic. Removed both.MainForm.cshad internal// Feature 1/2/3/4/5markers from earlier incremental changes. Replaced with plain descriptions (or removed where the code was already self-explanatory).60was repeated across four status strings and theCaptureAllcall. Extracted into a singleMainForm.ListenSecondsconstant.RawTlvsentry (Checksum: OK/Checksum: mismatch...). Kept informational rather than rejecting frames, since Ethernet padding can affect a naive byte-range guess and this shouldn't risk discarding an otherwise well-formed neighbour announcement.LinkData.Vlanis only populated by CDP's Native VLAN TLV; LLDP neighbours carry VLAN info viaPortVlanId(802.1 PVID) instead, so the report used to show an empty "Native VLAN" line for every LLDP-only neighbour. It's now only printed when CDP supplied it, consistent with the other optional fields.dotnet/LDWin.sln: there was no solution file; added one covering all three projects for local/IDE builds. (Individual CI jobs still restore/build their specific.csprojfiles, since the WinForms app project only builds on Windows.)Test plan
dotnet test dotnet/LDWin.Tests/LDWin.Tests.csproj -c Release— all 29 existing tests pass unchangeddotnet build dotnet/LDWin.Core/LDWin.Core.csproj -c Release— builds clean, 0 warnings/errorsChecksum: OK; a corrupted checksum byte reportsChecksum: mismatch (frame may be corrupt), and the frame still decodes (informational, non-rejecting)LDWin.exeapp itself, since building/running it requires Windows (this sandbox is Linux-only) —LDWin.Core(all logic touched by this PR) is Windows-independent and fully covered by the test projectGenerated by Claude Code