R1-02: CI pipeline v1 - #3
Merged
Merged
Conversation
Adds .github/workflows/pr.yml running on every pull request and push
to main (docs/build/CI_PLAN.md scope for R1-02):
- format: pinned clang-format 20.1.7 via pip so formatting is
reproducible across machines rather than dependent on a
contributor's local LLVM version. Verified locally that 20.1.7 and
the 22.x used to format the tree agree byte-for-byte.
- build matrix: linux {debug, asan-ubsan, release} + macos debug,
each configure/build/test through its preset with -Werror enabled
(CI-only, per BUILD_SYSTEM.md).
- ccache (also caches the gtest/benchmark compile) + FetchContent
source caching keyed on cmake/deps.cmake; per-ref concurrency with
cancel-in-progress.
tidy/deps/spec-coverage/python/bench-smoke jobs are intentionally
absent until their subjects exist (R1-24, R2, R1-23), so CI never
references tooling that is not yet in the tree.
README gains a developer section (build commands, canonical
clang-format version, contributing workflow, recommended branch
protection); BUILD_SYSTEM.md records the pinned clang-format version.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aravgarg28
added a commit
that referenced
this pull request
Jul 27, 2026
Adds .github/workflows/pr.yml running on every pull request and push
to main (docs/build/CI_PLAN.md scope for R1-02):
- format: pinned clang-format 20.1.7 via pip so formatting is
reproducible across machines rather than dependent on a
contributor's local LLVM version. Verified locally that 20.1.7 and
the 22.x used to format the tree agree byte-for-byte.
- build matrix: linux {debug, asan-ubsan, release} + macos debug,
each configure/build/test through its preset with -Werror enabled
(CI-only, per BUILD_SYSTEM.md).
- ccache (also caches the gtest/benchmark compile) + FetchContent
source caching keyed on cmake/deps.cmake; per-ref concurrency with
cancel-in-progress.
tidy/deps/spec-coverage/python/bench-smoke jobs are intentionally
absent until their subjects exist (R1-24, R2, R1-23), so CI never
references tooling that is not yet in the tree.
README gains a developer section (build commands, canonical
clang-format version, contributing workflow, recommended branch
protection); BUILD_SYSTEM.md records the pinned clang-format version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R1-02: CI pipeline v1 — Completion Report
Status: complete
Branch/PR:
task/R1-02-ciWhat was built
.github/workflows/pr.yml— CI on every pull request and push tomain(docs/build/CI_PLAN.md, R1-02 scope):clang-formatpinned to 20.1.7 via pip so formatting is reproducible across machines rather than dependent on a contributor's local LLVM version. Verified locally that 20.1.7 and the 22.x used to format the tree agree byte-for-byte.{debug, asan-ubsan, release}+ macOSdebug, each configure/build/test through its preset with-Werrorenabled (CI-only, per BUILD_SYSTEM.md).cmake/deps.cmake; per-ref concurrency with cancel-in-progress.tidy / deps / spec-coverage / python / bench-smoke jobs are intentionally absent until their subjects exist (R1-24, R2, R1-23), so CI never references tooling not yet in the tree.
README gains a developer section (build commands, canonical clang-format version, contributing workflow, recommended branch protection); BUILD_SYSTEM.md records the pinned clang-format version.
Acceptance criteria
pr.ymlwith format, linux-debug, linux-asan, linux-release, macos-debug — presentDeviations / Questions
stagecountpreset not added (see R1-01 report) — it needs pipeline stage counters that first exist in R3.Notes for reviewer
main, PRs R1-03: Core strong types #2 (R1-03) onward get automated checks.