Skip to content

fix(cdp,mcp): stabilize page linting noise - #309

Merged
aram-devdocs merged 50 commits into
mainfrom
codex/fix-noise-scoreboard-json
Jun 21, 2026
Merged

aram-devdocs merged 50 commits into
mainfrom
codex/fix-noise-scoreboard-json

Conversation

@aram-devdocs

@aram-devdocs aram-devdocs commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • wait for initialized CDP documents before reuse and navigate data: documents through CDP instead of script assignment
  • guard MCP lint_page_html documents with a fetch-blocking CSP while preserving doctype/head placement
  • ignore hidden Next.js route-announcer spacing infrastructure and update the Next e2e baseline

Verification

  • cargo fmt --all -- --check
  • cargo test -p plumb-cdp --lib
  • cargo test -p plumb-core --test golden_spacing_grid --test golden_spacing_scale
  • cargo test -p plumb-mcp --lib lint_page_html_guarded_document
  • cargo test -p plumb-mcp --all-features --test mcp_protocol lint_page_html -- --nocapture
  • cargo clippy -p plumb-core -p plumb-cdp -p plumb-mcp --all-targets --all-features -- -D warnings
  • RUSTDOCFLAGS=-Dwarnings cargo doc --workspace --no-deps
  • cargo build --release -p plumb-cli
  • PLUMB_BIN=target/release/plumb scripts/noise-scoreboard.sh --live
  • just validate
  • cargo run --release -p plumb-e2e -- --all --no-build --plumb-bin target/release/plumb --chrome-path "/tmp/plumb-cft150/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing"

Dogfood: release MCP lint_page_html against Vertice Labs raw page HTML now returns isError=false instead of timing out on data:.

@aram-devdocs
aram-devdocs marked this pull request as ready for review June 19, 2026 16:25
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

I have enough data to compose the final review. Let me confirm one more item.

@aram-devdocs
aram-devdocs force-pushed the codex/fix-noise-scoreboard-json branch 2 times, most recently from c6b56f8 to 1c6bcc4 Compare June 19, 2026 17:27
@aram-devdocs
aram-devdocs force-pushed the codex/fix-noise-scoreboard-json branch from 1c6bcc4 to 4cc2556 Compare June 19, 2026 17:47
@aram-devdocs
aram-devdocs force-pushed the codex/fix-noise-scoreboard-json branch 6 times, most recently from 792057f to ffbe75e Compare June 20, 2026 05:09
@aram-devdocs
aram-devdocs force-pushed the codex/fix-noise-scoreboard-json branch from 58d94cc to 381e592 Compare June 20, 2026 17:39
@aram-devdocs
aram-devdocs force-pushed the codex/fix-noise-scoreboard-json branch from 381e592 to 899985c Compare June 20, 2026 17:56
@aram-devdocs
aram-devdocs merged commit 627c4ec into main Jun 21, 2026
7 checks passed
@aram-devdocs
aram-devdocs deleted the codex/fix-noise-scoreboard-json branch June 21, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant