Skip to content

fix(automerge): count the review bot's two logins as one reviewer - #21

Merged
ChiragAgg5k merged 1 commit into
mainfrom
fix/review-bot-single-reviewer
Nov 9, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
fix/review-bot-single-reviewer

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

The review bot's app was renamed from hansi-codes to appwrite, and automerge.sh tracked the two logins as separate reviewers. A change request left by hansi-codes[bot] was never superseded, so a PR stayed blocked after the bot reviewed it again under the new login.

Both logins now count as one reviewer, and the bot's latest review of any kind is its verdict, since it sometimes posts its verdict as a comment. This only lifts the block: merging still needs an approval or Tier S on the head commit, and a major still needs a maintainer.

Verification

Dry runs against open PRs, main then this branch:

PR Before After
appwrite/defender#6 changes requested by hansi-codes[bot] 59561cb is not approved (Hansi: Tier B)
open-runtimes/examples#185 changes requested by appwrite[bot], hansi-codes[bot] changes requested by appwrite[bot]
appwrite/php-scrypt#2 would merge would merge
open-runtimes/examples#189 checks failed checks failed

GitHub's own review decision still shows the old change request, so a repository whose branch rules require reviews needs that review dismissed by hand.

Related: appwrite-labs/cloud#6671

A change request from hansi-codes[bot] was never superseded once the app was renamed to appwrite[bot], so PRs the bot had since approved stayed blocked.
@appwrite

appwrite Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The changed review evaluation matches the described behavior, and I found no actionable defect.

The automerge review check now treats the appwrite[bot] and hansi-codes[bot] accounts as one reviewer and uses the bot’s latest COMMENTED review when evaluating change requests. The README documents the updated reviewer behavior.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 2
File Change
.github/scripts/automerge.sh Combine the two review-bot logins and let its latest comment supersede an earlier change request.
README.md Document the bot’s unified reviewer identity and latest-review behavior.

Reviewed 2b91839 · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit 20647d1 into main Nov 9, 2026
2 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the fix/review-bot-single-reviewer branch November 9, 2026 20:50
@ChiragAgg5k ChiragAgg5k self-assigned this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant