Repository navigation
fix(automerge): count the review bot's two logins as one reviewer - #21
Merged
Merged
Conversation
A change request from hansi-codes[bot] was never superseded once the app was renamed to appwrite[bot], so PRs the bot had since approved stayed blocked.
🟢 Tier S · Ready to merge
The automerge review check now treats the
📂 Walkthrough · 2
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review bot's app was renamed from
hansi-codestoappwrite, andautomerge.shtracked the two logins as separate reviewers. A change request left byhansi-codes[bot]was never superseded, so a PR stayed blocked after the bot reviewed it again under the new login.Both logins now count as one reviewer, and the bot's latest review of any kind is its verdict, since it sometimes posts its verdict as a comment. This only lifts the block: merging still needs an approval or Tier S on the head commit, and a major still needs a maintainer.
Verification
Dry runs against open PRs,
mainthen this branch:GitHub's own review decision still shows the old change request, so a repository whose branch rules require reviews needs that review dismissed by hand.
Related: appwrite-labs/cloud#6671