Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN composer install --no-dev --no-interaction --no-progress --prefer-dist \
FROM oven/bun:1.4.4-alpine@sha256:4cf82f5686b196504fe119db3fcd9185b191f82ece82c40680e597228ec6070a AS bun

# PHP 8.5 with Swoole, Redis and igbinary: the runtime Appwrite's own workers read queues on.
FROM appwrite/base:2.2.9@sha256:ff6285b8621dd4863c6522737727904e109bd81f05e46b46dc2ef7e86d806b86
FROM appwrite/base:2.3.0@sha256:e9519544a2315be040f150625d07c0bb24693a043130fc9e5f628411d4dfd5a7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep consumer tests aligned with the runtime image

The consumer CI job and the documented local test command still use appwrite/base:2.2.9 (.github/workflows/ci.yml:39, README.md:261), so the consumer suite no longer runs in the image this Dockerfile ships. Please update those references too; the image smoke test does not run the consumer's PHPUnit suite against 2.3.0.

Prompt To Fix With AI
This is a comment left during a code review.
Path: Dockerfile
Line: 16

Comment:
**Keep consumer tests aligned with the runtime image**

The consumer CI job and the documented local test command still use `appwrite/base:2.2.9` (`.github/workflows/ci.yml:39`, `README.md:261`), so the consumer suite no longer runs in the image this Dockerfile ships. Please update those references too; the image smoke test does not run the consumer's PHPUnit suite against 2.3.0.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟑 Minor · testing · Reply if this doesn't apply.


# The review's tools run git (checkouts, history) and ripgrep (grep). Nothing from a reviewed
# repository runs in this container: commands go to orchestrator sandboxes.
Expand Down