Repository navigation
fix(engine): vertically centre the Status label on its image - #57
Merged
Merged
Conversation
align="center" is not a vertical-align keyword; browsers read it as -webkit-baseline-middle, which puts the image's centre on the text baseline and leaves the label riding high in the Status cell. align="absmiddle" maps to vertical-align: middle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F3M7tt2FDfxykLt6uoNuR7 Co-authored-by: Torsten Dittmann <1759475+TorstenDittmann@users.noreply.github.com>
Code review
The status image in summary and progress comments now uses Walkthrough (3)
Reviewed Tip Comment |
Merged
2 tasks done
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requested by Torsten · project thread
What
In the summary comment's Status cell, the label (Reviewed, Reviewing…) sat above the centre of the status image (e.g. appwrite-labs/cloud#7668).
align="center"is not a vertical-align keyword for<img>. Browsers map it to-webkit-baseline-middle, which puts the image's centre on the text baseline, so the label rides high.align="absmiddle"maps tovertical-align: middle, which centres the image on the text's middle.Checked
status-ready-light.pngat width 85:centergives image centre 31.0px vs text centre 25.0px (6px off);absmiddlegives 70.7px vs 69.1px.alignvalue verbatim (the renderedbody_htmlof the comment on cloud#7668 still carriesalign="center"), soabsmiddleshould pass the sanitizer too. Not yet confirmed on a live comment.bun run test,lint,checkpass.Appwrite's own Sites/Functions comments (
src/Appwrite/Vcs/Comment.php) use the samealign="center"and have the same offset; not touched here.Generated by Claude Code