Skip to content

fix(engine): vertically centre the Status label on its image - #57

Merged
TorstenDittmann merged 1 commit into
mainfrom
claude/project-thread-n1qjua
Nov 19, 2026
Merged

TorstenDittmann merged 1 commit into
mainfrom
claude/project-thread-n1qjua

Conversation

@TorstenDittmann

Copy link
Copy Markdown
Contributor

Requested by Torsten · project thread

What

In the summary comment's Status cell, the label (Reviewed, Reviewing…) sat above the centre of the status image (e.g. appwrite-labs/cloud#7668).

align="center" is not a vertical-align keyword for <img>. Browsers map it to -webkit-baseline-middle, which puts the image's centre on the text baseline, so the label rides high. align="absmiddle" maps to vertical-align: middle, which centres the image on the text's middle.

Checked

  • Rendered both in Chromium with the real status-ready-light.png at width 85: center gives image centre 31.0px vs text centre 25.0px (6px off); absmiddle gives 70.7px vs 69.1px.
  • GitHub keeps the align value verbatim (the rendered body_html of the comment on cloud#7668 still carries align="center"), so absmiddle should pass the sanitizer too. Not yet confirmed on a live comment.
  • bun run test, lint, check pass.

Appwrite's own Sites/Functions comments (src/Appwrite/Vcs/Comment.php) use the same align="center" and have the same offset; not touched here.


Generated by Claude Code

align="center" is not a vertical-align keyword; browsers read it as
-webkit-baseline-middle, which puts the image's centre on the text
baseline and leaves the label riding high in the Status cell.
align="absmiddle" maps to vertical-align: middle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F3M7tt2FDfxykLt6uoNuR7
Co-authored-by: Torsten Dittmann <1759475+TorstenDittmann@users.noreply.github.com>
@TorstenDittmann TorstenDittmann self-assigned this Nov 19, 2026
@appwrite

appwrite Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Code review

Commit Status Tier Verdict Details
c2a8d26 Reviewed Reviewed 🟢 S · Ready to merge ✅ Approved View review

The focused output change is consistent across summary and progress status cells, with their formatting expectations updated.

The status image in summary and progress comments now uses align="absmiddle" instead of align="center" so the label is vertically centered against the image. Formatting tests were updated to expect the new attribute.

Walkthrough (3)
File Change
packages/engine/src/format.ts Changes the status image alignment attribute and documents the intended vertical alignment.
packages/engine/src/format.test.ts Updates summary and status-cell formatting expectations for the new alignment attribute.
packages/engine/src/progress.test.ts Updates the progress status-row expectation for the new alignment attribute.

Reviewed c2a8d26

Tip

Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@TorstenDittmann
TorstenDittmann merged commit e2812f5 into main Nov 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants