Repository navigation
fix(engine): review SVG files instead of ignoring them - #55
Merged
Merged
Conversation
SVG sat in the default ignore list with raster images, but it is markup: it can carry scripts, event handlers and external references, and a site may serve it from its own origin. A pull request that only added an SVG was skipped with 'No reviewable changes', so it could never be approved.
Code review
Removes SVG files from the engine’s default ignore list so their markup can be included in reviews. Adds a filter test confirming SVG inclusion while raster images remain excluded. Walkthrough (2)
Reviewed Tip Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
**/*.svgwas indefaultIgnoreGlobsnext to PNG/JPG, so a pull request that only adds an SVG gets skipped with No reviewable changes and can never be approved (appwrite/appwrite#15774 addsbimi.svgserved from appwrite.io).SVG is text markup, not media:
Served from a first-party origin that's stored XSS, which is exactly what a review should catch. Raster images, fonts and PDFs stay ignored.
Test
filterFilesincore.test.tsgains a case: an added SVG is included, an added PNG is still excluded.