Skip to content

Revert finding settlement and reaction tracking - #54

Merged
TorstenDittmann merged 1 commit into
mainfrom
claude/project-thread-qtf7fe
Nov 18, 2026
Merged

TorstenDittmann merged 1 commit into
mainfrom
claude/project-thread-qtf7fe

Conversation

@TorstenDittmann

Copy link
Copy Markdown
Contributor

Reverts #53.

Appwrite will not add the settlement, upvotes and downvotes attributes or the findings reactions route (appwrite/appwrite#15776 is being closed), so Hansi stops sending them. Most fixes are made by agents, so 👍/👎 votes aren't a useful signal. Useful findings are derived instead from the resolved and dismissed statuses Appwrite already stores.

This restores the previous behavior: a thread resolved on GitHub dismisses its finding, and nothing reads reactions.

bun run lint, bun run check and bun run test pass locally.


Generated by Claude Code

Appwrite will not add the settlement, upvotes and downvotes attributes or
the findings reactions route, so stop sending them. Useful findings are
derived from the resolved and dismissed statuses Appwrite already stores.

This reverts commit a402d3b (merged in #53).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F3M7tvvVXXtaPKh5pzVnt3
Co-authored-by: Torsten Dittmann <1759475+TorstenDittmann@users.noreply.github.com>
@appwrite

appwrite Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Code review

Commit Status Tier Verdict Details
ee4bd27 Reviewed Reviewed 🟢 S · Ready to merge ✅ Approved View review

The revert removes the unsupported tracking while preserving the thread-resolution behavior.

This removes finding settlement metadata and reaction tracking from the engine, Appwrite sink, and GitHub thread client. Findings are still dismissed when a repository writer resolves their GitHub thread.

Walkthrough (13)
File Change
packages/appwrite/src/results.test.ts Removes coverage for settlement and reaction API writes.
packages/appwrite/src/results.ts Removes settlement serialization and reaction updates from the Appwrite sink.
packages/engine/src/chat-job.test.ts Updates the chat settlement assertion to check status only.
packages/engine/src/chat-job.ts Removes reaction recording and settlement metadata from chat handling.
packages/engine/src/github.ts Removes reaction counts from the engine thread contract.
packages/engine/src/resolved-threads.test.ts Removes reaction-change unit coverage.
packages/engine/src/resolved-threads.ts Retains dismissal for resolved threads and removes reaction tracking.
packages/engine/src/results.ts Removes settlement and reaction types from result records and sink contracts.
packages/engine/src/review-job.test.ts Removes settlement and reaction assertions, retaining the thread-dismissal scenario.
packages/engine/src/review-job.ts Uses the renamed thread-dismissal helper and omits settlement metadata.
packages/engine/src/testing.ts Removes reaction storage and settlement support from in-memory fakes.
packages/github/src/pulls.test.ts Removes the test for reading thread reaction counts.
packages/github/src/pulls.ts Drops reaction fields from the GraphQL query and thread results.

Reviewed ee4bd27

Tip

Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@TorstenDittmann
TorstenDittmann merged commit 6e93d2a into main Nov 18, 2026
4 checks passed
@TorstenDittmann
TorstenDittmann deleted the claude/project-thread-qtf7fe branch November 18, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants