Repository navigation
Revert finding settlement and reaction tracking - #54
Merged
Merged
Conversation
Appwrite will not add the settlement, upvotes and downvotes attributes or the findings reactions route, so stop sending them. Useful findings are derived from the resolved and dismissed statuses Appwrite already stores. This reverts commit a402d3b (merged in #53). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F3M7tvvVXXtaPKh5pzVnt3 Co-authored-by: Torsten Dittmann <1759475+TorstenDittmann@users.noreply.github.com>
Code review
This removes finding settlement metadata and reaction tracking from the engine, Appwrite sink, and GitHub thread client. Findings are still dismissed when a repository writer resolves their GitHub thread. Walkthrough (13)
Reviewed Tip Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reverts #53.
Appwrite will not add the
settlement,upvotesanddownvotesattributes or the findings reactions route (appwrite/appwrite#15776 is being closed), so Hansi stops sending them. Most fixes are made by agents, so 👍/👎 votes aren't a useful signal. Useful findings are derived instead from theresolvedanddismissedstatuses Appwrite already stores.This restores the previous behavior: a thread resolved on GitHub dismisses its finding, and nothing reads reactions.
bun run lint,bun run checkandbun run testpass locally.Generated by Claude Code