Skip to content

Lay the summary comment out like the Sites and Functions comments - #52

Merged
TorstenDittmann merged 2 commits into
mainfrom
claude/project-thread-xdri97
Nov 18, 2026
Merged

TorstenDittmann merged 2 commits into
mainfrom
claude/project-thread-xdri97

Conversation

@TorstenDittmann

@TorstenDittmann TorstenDittmann commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Torsten · project thread

What

Hansi's summary comment now follows the layout of Appwrite's Sites and Functions deployment comments (Appwrite\Vcs\Comment):

  • Head row. A table in the shape of a deployment row: commit, status, tier, verdict and a link to the review in the Console. It replaces the tier heading and the verdict/counts table.
  • Same progress indicator. The status cell uses the state images Appwrite serves under /images/vcs/. The animated one shows while a review runs (with the phase as its label: "Reviewing 12 files", "Verifying 2 possible findings"), then ready, queued (interrupted, retrying) or failed. The status block at the top of a running review is that same row, plus "Follow along".
  • Counted sections. Findings and unattached findings are open <details> sections; walkthrough, still open, fixed and filtered out stay collapsed. Each title carries its count, as "Sites (2)" does.
  • Tip. The comment ends with a > [!TIP] on how to re-run or ask, where Appwrite puts its tip.

Providers

Images are on for GitHub, GitLab, Bitbucket and Gitea, and off for Origin, matching supportsCommentImages() in packages/vcs. Off means the label alone (_Reviewing 12 files_), which is what Appwrite writes there. The images load from the Appwrite host the job names in the new optional repository.imagesUrl (statusImagesOrigin in shared.ts). It is not consoleUrl, because on Cloud the Console host (appwrite.io) doesn't serve /images/vcs/ and cloud.appwrite.io does. appwrite/appwrite#15771 sends it. Until then, or for any job without it, the status is text.

Compatibility

The latest-changes paragraph used to end at the old | Verdict | table, which settlement rebuilds used to read it back. It now ends at a hidden latest-changes marker. latestChangesFromBody reads both, so summaries posted before this deploy still rebuild correctly.

Preview

Finished review (🖼️ marks the Appwrite status image, light and dark, which the PR body can't embed):

Code review

Commit Status Tier Verdict Details
abcdef1 🖼️ready Reviewed 🟡 B · Needs changes before merging 🛑 Changes requested View review

Limited by an open major finding: Off by one

Adds cursor pagination to the items endpoint.

Findings (1)
Finding Where
🟠 Off by one skips the first page src/paginate.ts:3
Walkthrough (1)
File Change
src/paginate.ts Switches to cursor pages.
Fixed since the last review (1)
  • Missing await · src/a.ts:9

Reviewed abcdef1

Tip

Comment @appwrite review to re-run, or mention @appwrite with a question.

A later review while it runs (sits above the previous summary):

Commit Status Details
1234567 🖼️building Reviewing 12 files Follow along

The summary below is from the previous review.

Testing

  • Fixture tests for the head row, status cell (with and without images, every state), sections, tip, latest-changes round trip (new and old format) and statusImagesOrigin across all five providers.
  • bun run format, bun run lint, bun run check, bun run test: 460 pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01F3M7tukAPsZ8K2YWuskhgg

The summary opens with a head row (commit, status, tier, verdict, details)
in the shape of a deployment row, and the status cell uses the same state
images Appwrite serves from the Console: the animated one while a review
runs, then ready, queued or failed. Findings, walkthrough, still-open,
fixed and filtered findings are counted collapsible sections, and the
comment ends with a tip on how to re-run or ask.

Origin gets the labels without images, as it does for Appwrite's own
comments, and so does any repository without a Console root.

The latest-changes paragraph now ends at a hidden marker, so a settlement
rebuild reads it back without the old verdict table; old summaries still
parse.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F3M7tukAPsZ8K2YWuskhgg
Co-authored-by: Torsten Dittmann <1759475+TorstenDittmann@users.noreply.github.com>
@TorstenDittmann TorstenDittmann self-assigned this Nov 18, 2026
@appwrite

appwrite Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The summary comment now follows Appwrite’s deployment-comment layout, with a deployment-style status row, counted collapsible sections, and a re-run/question tip. Live progress uses the same row, while settlement can recover latest-changes text from both the new and old summary formats. Status images are provider-aware and use the Appwrite image host supplied with the job, falling back to text when it is absent.

Latest changes: The newest commits add an optional imagesUrl repository field to the job contract and switch status-image origin selection from consoleUrl to that host, with parsing and behavior tests for older payloads that omit it.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 17
File Change
packages/appwrite/src/payload.test.ts Tests parsing valid optional image hosts and rejecting malformed ones.
packages/appwrite/src/payload.ts Accepts an optional imagesUrl in repository job payloads.
packages/engine/src/chat-job.ts Passes the provider-aware status image origin into chat settlement summary refreshes.
packages/engine/src/core.test.ts Updates summary assertions for the redesigned comment layout.
packages/engine/src/format.test.ts Covers status rows, image variants, counted sections, the tip, and latest-changes compatibility.
packages/engine/src/format.ts Renders the deployment-style summary layout and reads latest-changes text from old and new formats.
packages/engine/src/jobs.ts Adds the optional repository image-host field to the engine job contract.
packages/engine/src/merge-only.test.ts Updates carried-summary assertions for the redesigned layout.
packages/engine/src/merge-only.ts Passes status image origin into merge-only summaries.
packages/engine/src/progress.test.ts Tests the deployment-style progress row and its status images.
packages/engine/src/progress.ts Renders live review progress as a status row with phase labels and optional images.
packages/engine/src/review-job.test.ts Updates completed-review fixtures and assertions for the new summary layout.
packages/engine/src/review-job.ts Supplies the status image origin to progress, review summaries, and merge-only summaries.
packages/engine/src/shared.test.ts Tests status image host selection, including unsupported providers and missing or invalid hosts.
packages/engine/src/shared.ts Derives status image origin from the optional job imagesUrl, rather than the Console URL.
packages/engine/src/summary.test.ts Updates settlement summary assertions for the new layout and latest-changes recovery.
packages/engine/src/summary.ts Preserves latest-changes text across settlement rebuilds and passes the image origin into summaries.

Reviewed the commits since 66cdf59 · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

On Cloud the Console (appwrite.io) does not serve /images/vcs/; the
Appwrite host (cloud.appwrite.io) does, as consoleHostname in Appwrite's
own comments. Appwrite names it as repository.imagesUrl; without it the
status stays text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F3M7tukAPsZ8K2YWuskhgg
Co-authored-by: Torsten Dittmann <1759475+TorstenDittmann@users.noreply.github.com>
@TorstenDittmann
TorstenDittmann merged commit 97abff5 into main Nov 18, 2026
4 checks passed
@TorstenDittmann
TorstenDittmann deleted the claude/project-thread-xdri97 branch November 18, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants