Repository navigation
fix(engine): report only the advisories a dependency change adds - #40
Closed
ChiragAgg5k wants to merge 1 commit into
Closed
ChiragAgg5k wants to merge 1 commit into
ChiragAgg5k wants to merge 1 commit into
Conversation
A security fix that still left another advisory open got a change request, so pull requests that only reduced exposure never merged.
🟢 Tier S · Ready to mergeThe dependency-review prompt now asks reviewers to report vulnerabilities only when a dependency update introduces an advisory that did not affect the replaced version. It clarifies that pre-existing advisories and unchanged packages are not findings.
📂 Walkthrough · 1
🔇 Filtered out · 1Findings Hansi considered but did not post.
Reviewed |
Member
Author
|
Closing: this repository is no longer where reviews run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a dependency PR the review prompt says to report any known vulnerability an audit tool shows in a locked version. A security fix that moves a package to a version still covered by another advisory therefore gets a change request, although the PR only reduces exposure, and it never merges.
The prompt now asks for a finding only when the PR adds the advisory: the new version is affected by one the replaced version was not. An advisory that also affects the replaced version, or a package the PR doesn't change, is not a finding.
Open Renovate security PRs blocked this way on 9 November:
Verification
bun run lint,bun run checkandbun run testpass (373 tests). The prompt text itself is only exercised by a live review: re-request one onappwrite/orbit-integrations#1after deploy.