Skip to content

fix(engine): report only the advisories a dependency change adds - #40

Closed
ChiragAgg5k wants to merge 1 commit into
appwrite:mainfrom
ChiragAgg5k:fix/dependency-review-inherited-advisories
Closed

ChiragAgg5k wants to merge 1 commit into
appwrite:mainfrom
ChiragAgg5k:fix/dependency-review-inherited-advisories

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

On a dependency PR the review prompt says to report any known vulnerability an audit tool shows in a locked version. A security fix that moves a package to a version still covered by another advisory therefore gets a change request, although the PR only reduces exposure, and it never merges.

The prompt now asks for a finding only when the PR adds the advisory: the new version is affected by one the replaced version was not. An advisory that also affects the replaced version, or a package the PR doesn't change, is not a finding.

Open Renovate security PRs blocked this way on 9 November:

PR Finding
appwrite/orbit-integrations#1 Axios 0.33.0 is still in vulnerable ranges
open-runtimes/examples#185 axios 0.33.0 is still in the vulnerable range
appwrite/defender#6 @vitest/mocker 4.1.11 remains vulnerable
appwrite/snapwrite#8 Rollup 4.53.1 is affected by an arbitrary-file-write advisory

Verification

bun run lint, bun run check and bun run test pass (373 tests). The prompt text itself is only exercised by a live review: re-request one on appwrite/orbit-integrations#1 after deploy.

A security fix that still left another advisory open got a change request, so pull requests that only reduced exposure never merged.
@appwrite

appwrite Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The dependency-review prompt now asks reviewers to report vulnerabilities only when a dependency update introduces an advisory that did not affect the replaced version. It clarifies that pre-existing advisories and unchanged packages are not findings.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 1
File Change
packages/engine/src/prompts.ts Updated the dependency vulnerability review instruction to compare the new version with the replaced version.
🔇 Filtered out · 1

Findings Hansi considered but did not post.

Finding Why
Add coverage for the new vulnerability comparison rule Verifier: The change is a wording edit to model prompt text. A test could only assert that a string is present, which doesn't show the model's behavior. The existing test checks that the section is included and the version list, not the wording of each rule. Asking for a test of this wording is a nit.

Reviewed b1c9872 · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Closing: this repository is no longer where reviews run.

@ChiragAgg5k ChiragAgg5k closed this Nov 9, 2026
@ChiragAgg5k
ChiragAgg5k deleted the fix/dependency-review-inherited-advisories branch November 9, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant