Skip to content

fix: upgrade distro packages in the final stage - #21

Merged
ChiragAgg5k merged 1 commit into
mainfrom
chore-apk-upgrade
Nov 13, 2026
Merged

ChiragAgg5k merged 1 commit into
mainfrom
chore-apk-upgrade

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Adds RUN apk upgrade --no-cache right after the final stage FROM, so a rebuild picks up Alpine package fixes even when the base image digest hasn't moved. This is what lets the daily fixable-CVE rebuild job in appwrite/renovate-config cut a patch release when a fresh build scans cleaner than the published tag.

Related: appwrite-labs/cloud#6671

Packages from the base image and from `apk add` only pick up Alpine security fixes when the build upgrades them, so a rebuild without a base digest change shipped the same vulnerable versions. The daily CVE rebuild job in appwrite/renovate-config relies on a fresh build picking up those fixes.
@appwrite

appwrite Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The package upgrade is a standard Alpine operation and the changed build step introduces no concrete defect.

The final image stage now upgrades installed Alpine packages before adding the application files. This lets fresh builds use newer packages from the configured Alpine repositories without changing the pinned base-image tag.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 1
File Change
Dockerfile Added an Alpine package upgrade in the final image stage.

Reviewed 69012e7 · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit c62ef9a into main Nov 13, 2026
4 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the chore-apk-upgrade branch November 13, 2026 14:26
@ChiragAgg5k ChiragAgg5k self-assigned this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant