Skip to content

ci: build the example on the Node floor of the locked astro - #25

Merged
TorstenDittmann merged 1 commit into
appwrite:mainfrom
ChiragAgg5k:ci-example-astro-node-floor
Nov 16, 2026
Merged

TorstenDittmann merged 1 commit into
appwrite:mainfrom
ChiragAgg5k:ci-example-astro-node-floor

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

astro 7.4.7 (security bump in #24) requires Node >=22.23.4, so the example build moves from 22.12.0 to 22.23.4. The package engines.node stays >=22.12.0 and the "Test on Node.js 22.12.0" lane keeps covering it.

The required check "Build the example on Node.js 22.12.0" becomes "Build the example on Node.js 22.23.4". .github/rulesets/main.json is updated; an admin needs to apply the same rename to the live ruleset when merging.

Related: appwrite-labs/cloud#6671

astro 7.4.7 (the security bump in appwrite#24) requires Node >=22.23.4, so building the example on 22.12.0 runs astro outside its supported range. The package floor stays at 22.12.0 and keeps its test lane.
@appwrite

appwrite Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The example-build matrix now runs on Node.js 22.23.4 and 24, while the package test matrix continues covering Node.js 22.12.0. The required status-check context in the main ruleset is updated to match the renamed example-build job.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 2
File Change
.github/workflows/ci.yml Moves the example build's lower Node.js matrix entry to 22.23.4.
.github/rulesets/main.json Updates the required status-check name for the Node.js 22.23.4 example build.

Reviewed 5071d38 · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@TorstenDittmann
TorstenDittmann merged commit e710d67 into appwrite:main Nov 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants