Repository navigation
ci: build the example on the Node floor of the locked astro - #25
Merged
TorstenDittmann merged 1 commit intoNov 16, 2026
Merged
Conversation
astro 7.4.7 (the security bump in appwrite#24) requires Node >=22.23.4, so building the example on 22.12.0 runs astro outside its supported range. The package floor stays at 22.12.0 and keeps its test lane.
🟢 Tier S · Ready to mergeThe example-build matrix now runs on Node.js 22.23.4 and 24, while the package test matrix continues covering Node.js 22.12.0. The required status-check context in the main ruleset is updated to match the renamed example-build job.
📂 Walkthrough · 2
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astro 7.4.7 (security bump in #24) requires Node
>=22.23.4, so the example build moves from 22.12.0 to 22.23.4. The packageengines.nodestays>=22.12.0and the "Test on Node.js 22.12.0" lane keeps covering it.The required check "Build the example on Node.js 22.12.0" becomes "Build the example on Node.js 22.23.4".
.github/rulesets/main.jsonis updated; an admin needs to apply the same rename to the live ruleset when merging.Related: appwrite-labs/cloud#6671