#1 fix issue about reading correct schema with allOff, create eclips…

[pisua]

@djodjoni

Hi,
First of all, thanks for you API that allows to generate fake JSON based on JSON schema. As We need this kind of tool in java that are rare to find open source, I was great to see that one.

During my usage, I've detected 2 issues that I've fix in my fork.

• One about a bad if test for allOf merging In the json-generator
• Another one in the json-core and json-schema about default value assign while call optInt, optString.

Also during the project fork as we run using maven and eclipse, I've also manage to have eclipse project and pom.xml. This doesn't impact the gradle build

Finally, I've made some improvements about json-generator, in order to allow to generate empty JSON base on the schema using the configuration (boolean parameter emptyJson) and also use a lib that allow to generate String base on regular expression.

I let you have a see if you can integrate these in you GitHub repo. If you need a version without the improvement I can push a branch with only my fixes.
Plus if you have some question don't hesitate to send me an email or a GitHub notification.

Regards,
Aurélien Pisu

[djodjoni]

Hi @pisua. Thx for the interest and the PR I'm really happy you found a use of this lib :)
It all sounds OK but the tests are failing. Could you try and fix those, please .

[pisua]

I’ve check with gradle and in deed, I’ve forget to set the dependency to the regex generation lib. I’ll look on it and fix it in my fork. I’ll keep you inform.

…

Le 5 juil. 2017 à 22:24, Kalin Maldzhanski ***@***.***> a écrit : Hi @pisua <https://github.com/pisua>. Thx for the interest and the PR I'm really happy you found a use of this lib :) It all sounds OK but the tests are failing. Could you try and fix those, please . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB5IGlf0_ly5u-C_2Sg3I3P3W0xyn0DBks5sK_D8gaJpZM4OOk1K>.

[pisua]

@djodjoni
I’ve fixed it in my fork. Just align the unit test to be ok with the right behavior concerning the change that I've made and to be align with the spec for optInt, optBoolean and optString.
i let you check in your side.
Thanks,
Regards

[djodjoni]

Ok Ill take a look at it in the next days