-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: replace generic "Response not valid" with actionable error messages for better observability #41769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
subrata71
wants to merge
3
commits into
release
Choose a base branch
from
fix/response-not-valid
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: replace generic "Response not valid" with actionable error messages for better observability #41769
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
8da9ca6
fix(actions): replace generic "Response not valid" with actionable er…
subrata71 f695136
fix(actions): drop datasource URL from error log to avoid leaking que…
subrata71 ce142c5
fix(actions): use debug log level for upstream API failures, keep war…
subrata71 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import { extractExecutionErrorMessage } from "./errorUtils"; | ||
|
|
||
| describe("extractExecutionErrorMessage", () => { | ||
| it("returns timeout message for Axios ECONNABORTED with timeout pattern", () => { | ||
| const axiosError = Object.assign(new Error("timeout of 10000ms exceeded"), { | ||
| code: "ECONNABORTED", | ||
| isAxiosError: true, | ||
| }); | ||
|
|
||
| expect(extractExecutionErrorMessage(axiosError)).toBe( | ||
| "Action execution timed out. Try increasing the timeout in the action settings.", | ||
| ); | ||
| }); | ||
|
|
||
| it("returns network error message for Axios Network Error", () => { | ||
| const axiosError = Object.assign(new Error("Network Error"), { | ||
| isAxiosError: true, | ||
| }); | ||
|
|
||
| expect(extractExecutionErrorMessage(axiosError)).toBe( | ||
| "Network error: could not reach the Appsmith server. Check your connection.", | ||
| ); | ||
| }); | ||
|
|
||
| it("returns Axios message for other Axios errors", () => { | ||
| const axiosError = Object.assign( | ||
| new Error("Request failed with status code 502"), | ||
| { isAxiosError: true }, | ||
| ); | ||
|
|
||
| expect(extractExecutionErrorMessage(axiosError)).toBe( | ||
| "Request failed: Request failed with status code 502", | ||
| ); | ||
| }); | ||
|
|
||
| it("returns Axios message for ECONNABORTED without timeout pattern", () => { | ||
| const axiosError = Object.assign(new Error("connection aborted"), { | ||
| code: "ECONNABORTED", | ||
| }); | ||
|
|
||
| expect(extractExecutionErrorMessage(axiosError)).toBe( | ||
| "Request failed: connection aborted", | ||
| ); | ||
| }); | ||
|
|
||
| it("returns server error message from validateResponse errors", () => { | ||
| const serverError = new Error("Organization not found"); | ||
|
|
||
| expect(extractExecutionErrorMessage(serverError)).toBe( | ||
| "Organization not found", | ||
| ); | ||
| }); | ||
|
|
||
| it("returns 'Response not valid' for non-Error values", () => { | ||
| expect(extractExecutionErrorMessage("string error")).toBe( | ||
| "Response not valid", | ||
| ); | ||
| expect(extractExecutionErrorMessage(null)).toBe("Response not valid"); | ||
| expect(extractExecutionErrorMessage(undefined)).toBe("Response not valid"); | ||
| expect(extractExecutionErrorMessage(42)).toBe("Response not valid"); | ||
| }); | ||
|
|
||
| it("returns 'Response not valid' for Error with empty message", () => { | ||
| expect(extractExecutionErrorMessage(new Error(""))).toBe( | ||
| "Response not valid", | ||
| ); | ||
| }); | ||
|
|
||
| it("returns the error message for a plain Error", () => { | ||
| const error = new Error("Something went wrong"); | ||
|
|
||
| expect(extractExecutionErrorMessage(error)).toBe("Something went wrong"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include throwable in WARN log to preserve stack trace
At Line 886, the warn log currently emits only
error.getMessage(). In production (where DEBUG is often off), this drops stack-trace context for unexpected failures.Suggested patch
📝 Committable suggestion
🤖 Prompt for AI Agents