-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(frontend): trigger numeric keypad for Currency Input on iOS #41731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Arbab1308
wants to merge
16
commits into
appsmithorg:release
Choose a base branch
from
Arbab1308:fix/currency-inputmode-clean
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
92979da
feat(types): add InputMode enum for HTML5 inputmode attribute support
Arbab1308 8f24196
feat(input): add inputmode mapping for mobile keyboard optimization
Arbab1308 45039fd
fix(currency-input): enable numeric keypad on iOS with inputmode support
Arbab1308 8d37cd4
feat(types): add InputMode enum for HTML5 inputmode attribute support
Arbab1308 84c68a2
feat(input): add inputmode mapping for mobile keyboard optimization
Arbab1308 39310aa
fix(currency-input): enable numeric keypad on iOS with inputmode support
Arbab1308 8372555
Merge branch 'release' into fix/currency-inputmode-clean
sebastianiv21 f161147
Merge branch 'fix/currency-inputmode-clean' of https://github.com/Arb…
Arbab1308 05005b5
test: add getInputMode unit tests and use InputMode enum
Arbab1308 c044cb2
test: move getInputMode test under __tests__
Arbab1308 cf3dc67
fix: add InputMode.NONE for HTML inputmode
Arbab1308 f502be0
refactor: export getInputMode helper for tests
Arbab1308 73c0b02
chore: fix lint/prettier and stabilize getInputMode tests
Arbab1308 3ba718a
test: fix getInputMode test
Arbab1308 aece43c
chore: fix lint/prettier and getInputMode tests
Arbab1308 97e1ac9
Merge branch 'release' into fix/currency-inputmode-clean
sebastianiv21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
app/client/src/widgets/BaseInputWidget/component/__tests__/getInputMode.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { InputMode } from "../../constants"; | ||
| import { getInputMode } from "../index"; | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| describe("getInputMode", () => { | ||
| it('maps NUMBER to InputMode.DECIMAL ("decimal")', () => { | ||
| expect(getInputMode("NUMBER")).toBe(InputMode.DECIMAL); | ||
| }); | ||
|
|
||
| it('maps TEL to InputMode.TEL ("tel")', () => { | ||
| expect(getInputMode("TEL")).toBe(InputMode.TEL); | ||
| }); | ||
|
|
||
| it('maps EMAIL to InputMode.EMAIL ("email")', () => { | ||
| expect(getInputMode("EMAIL")).toBe(InputMode.EMAIL); | ||
| }); | ||
|
|
||
| it("returns undefined for default/unknown type", () => { | ||
| expect(getInputMode()).toBeUndefined(); | ||
| expect(getInputMode("TEXT")).toBeUndefined(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.