Skip to content

Conversation

@VladyslavTy
Copy link

Change description

Bryans comments:

In order to make edx-jwt-… a session cookies, we’d have to use response.set_cookie without setting an expires param, which should make it session. There’s a method user_authn.cookies._create_and_set_jwt_cookies which sets these. It calls _set_expires_in_cookie_settings, passing in settings.JWT_AUTH['JWT_IN_COOKIE_EXPIRATION']. Can that be set to a None or something? No, _set_expires_in_cookie_settings this assumes an integer passed in. So, can’t make this a session cookie withiout any direct change to the edx-platform code.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix ENG-321

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@VladyslavTy VladyslavTy changed the base branch from main to appsembler/master April 19, 2024 14:34
@VladyslavTy VladyslavTy changed the base branch from appsembler/master to main April 19, 2024 14:34
@VladyslavTy VladyslavTy changed the base branch from main to appsembler/psu-temp-tahoe-juniper April 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants