Skip to content

Allow building under library evolution on Xcode 26.5 / Swift 6.3 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leogdion wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow building under library evolution on Xcode 26.5 / Swift 6.3 #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Sources/OpenAPIURLSession/BufferedStream/Lock.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,15 @@ final class LockStorage<Value>: ManagedBuffer<Value, LockPrimitive> {
}
}

// Under `-enable-library-evolution` (BUILD_LIBRARY_FOR_DISTRIBUTION=YES),
// Swift 6.3+ rejects an `@inlinable` deinit on a non-`@_fixed_layout` class:
// "deinitializer can only be '@inlinable' if the class is '@_fixed_layout'".
// Consumers that build this package resiliently can define
// OPENAPIURLSESSION_NONINLINABLE_LOCK to drop the attribute; the default
// build is unchanged.
#if !OPENAPIURLSESSION_NONINLINABLE_LOCK
@inlinable
#endif
deinit {
self.withUnsafeMutablePointerToElements { lockPtr in
LockOperations.destroy(lockPtr)
Expand Down Expand Up @@ -231,7 +239,12 @@ struct Lock {
internal let _storage: LockStorage<Void>

/// Create a new lock.
// Under library evolution, an `@inlinable` init may not directly initialize
// the stored `_storage` property unless the type is `@frozen`. Consumers
// building resiliently can define OPENAPIURLSESSION_NONINLINABLE_LOCK.
#if !OPENAPIURLSESSION_NONINLINABLE_LOCK
@inlinable
#endif
init() {
self._storage = .create(value: ())
}
Expand Down Expand Up @@ -309,7 +322,11 @@ struct LockedValueBox<Value> {
internal let _storage: LockStorage<Value>

/// Initialize the `Value`.
// See note above: `@inlinable` init cannot initialize stored `_storage`
// directly under library evolution unless the type is `@frozen`.
#if !OPENAPIURLSESSION_NONINLINABLE_LOCK
@inlinable
#endif
init(_ value: Value) {
self._storage = .create(value: value)
}
Expand Down