Conversation
rpaulo
commented
Sep 16, 2026
rpaulo
commented
Contributor
- Add RX transport checksum validation flags and hardware checksum value reporting
- Add TX partial-checksum offload start/store offsets
- Add TSO segment size and IPv6 super-packet support
- Fix inverted guard conditions in aggregate buffer length handling
rpaulo
requested review from
agnosticdev,
ekinnear and
tfpauly
as code owners
September 16, 2026 22:52
- Add RX transport checksum validation flags and hardware checksum value reporting - Add TX partial-checksum offload start/store offsets - Add TSO segment size and IPv6 super-packet support - Fix inverted guard conditions in aggregate buffer length handling
rpaulo
force-pushed
the
frame-checksum
branch
from
September 16, 2026 23:10
0af2fa0 to
4fe14ed
Compare
tfpauly
reviewed
Sep 16, 2026
| final class SwiftNetworkFrameTests: XCTestCase { | ||
| func testFrameLayout() { | ||
| XCTAssertEqual(MemoryLayout<Frame>.size, 136) | ||
| XCTAssertEqual(MemoryLayout<Frame>.stride, 136) |
Collaborator
There was a problem hiding this comment.
It would be great to find a way to not increase the size for most frames, but I don't see a great option at this point.
Contributor
Author
There was a problem hiding this comment.
If this is a problem for embedded, maybe we could not support checksum offloading there and make this structure smaller?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.