Stop using Foundation on platforms with FoundationEssentials#108
Merged
guoye-zhang merged 2 commits intoapple:mainfrom Oct 21, 2025
Merged
Stop using Foundation on platforms with FoundationEssentials#108guoye-zhang merged 2 commits intoapple:mainfrom
guoye-zhang merged 2 commits intoapple:mainfrom
Conversation
|
Depends on how strictly you interpret SemVer, but I believe removing all public Foundation imports from a module is technically an API break. Unlikely to affect many adopters, but might break some, so just something to be aware of. |
FranzBusch
approved these changes
Oct 21, 2025
Member
FranzBusch
left a comment
FranzBusch
left a comment
There was a problem hiding this comment.
LGTM! Last we discussed this we said while this is strictly speaking a breaking change we are accepting it.
Lukasa
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #107