Repository navigation
feat: materialize Reatom agent skills with APM - #53
Merged
Merged
Conversation
Declare Reatom agent skills in apm.yml and install them through a new [deps.skills] mise dependency provider. Skills deploy into .agents/skills (agent-skills target), which stays gitignored and is reproduced by 'apm install' from the committed apm.lock.yaml (hash-pinned). - pin APM to a git commit: released 0.4.3 rejects SKILL_BUNDLE packages - ignore .agents/skills and apm_modules/ - document the workflow in docs/tooling.md
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
APM v0.33.0 (released yesterday) supports SKILL_BUNDLE installs, so the provider now uses the registry-backed apm tool pinned in _config.toml rather than a uvx git build.
- pin cursor/plugins unslop (repo-local so every clone gets it, matching the machine-wide skill set) - add skills:update mise task (apm install --update) - add weekly skills-update workflow that opens a PR when refs move
hk is pinned to latest in mise and now resolves to 2.x, which cannot evaluate a config amending the v1.46.0 schema package (pklr fails with "listing index amendment requires an Int index"), so prepare:git-hooks - and with it the whole test workflow - dies before any checks run. hk 2.4.0 validates and installs hooks cleanly against its own v2.4.0 package, matching what hk init generates.
- add cursor/plugins typescript-best-practices to apm.yml - strip disable-model-invocation from unslop and the TS guide via a post-install lifecycle hook (scripts/patch-skills.sh)
Contributor
Fallow audit reportNo GitHub PR/MR findings. Generated by fallow. |
Replace the weekly skills-update workflow with a hk 'skills-lock' check (scripts/check-skills-lock.sh): fails when apm.yml and apm.lock.yaml drift, warns on outdated upstream refs. 'mise run skills:update' stays for manual bumps.
scripts/sync-skills.sh syncs apm.yml refs from node_modules: kahraman tracks its exact release tag; reatom re-resolves the v1001 branch head when @reatom/core's installed version moves (recorded in .config/skill-deps.txt). Wired into the mise deps skills provider and the hk skills-lock step (check/fix).
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved lock invalidation, CI enforcement, and freshness-check issues remain.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds APM-managed Reatom agent skills with mise installation, lockfile pinning, lifecycle patching, and documentation.
Changes:
- Declares and pins skill dependencies.
- Adds automatic mise-based skill materialization and update tooling.
- Adds lock validation and documents installation workflows.
| File | Summary |
|---|---|
scripts/patch-skills.sh |
Adjusts fetched skill metadata. |
scripts/check-skills-lock.sh |
Validates lock synchronization and freshness; freshness handling needs correction. |
docs/tooling.md |
Documents skill installation and maintenance; CI enforcement claim needs correction. |
apm.yml |
Defines skill dependencies and lifecycle hooks. |
apm.lock.yaml |
Pins resolved skill commits and hashes. |
.gitignore |
Ignores generated APM outputs. |
.config/mise/conf.d/tasks-skills.toml |
Adds the skill update task. |
.config/mise/conf.d/_config.toml |
Configures automatic skill installation; lockfile changes must invalidate the provider. |
.config/hk.pkl |
Registers the lock check; CI integration remains unresolved. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…k in CI The skills dependency provider ignored apm.lock.yaml, so a checkout or update that changed only the lock left .agents/skills stale even though the pinned commits and hashes moved; include it in sources. The docs claimed the skills-lock check runs in CI, but 'mise run ci' never invoked hk check, so nothing enforced it there; wire the check into the ci task as lint:skills-lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apm.ymland pin its resolved files inapm.lock.yaml.skillsdependency provider using a pinned APM commit; ignore the generated files.Testing