feat(quartz): add misfire original fire time column mapping#70
Open
JasonLandbridge wants to merge 1 commit intoappany:mainfrom
Open
feat(quartz): add misfire original fire time column mapping#70JasonLandbridge wants to merge 1 commit intoappany:mainfrom
JasonLandbridge wants to merge 1 commit intoappany:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Quartz 3.17’s optional
MISFIRE_ORIG_FIRE_TIMEtrigger column in the EF Core schema mappings used by this repo.Related release note: https://github.com/quartznet/quartznet/releases/tag/v3.17.0
Problem
Quartz introduced an optional
MISFIRE_ORIG_FIRE_TIMEcolumn onQRTZ_TRIGGERSto preserve the original scheduled fire time for misfired triggers when using “fire now” policies.Without this column in our EF model mappings:
ScheduledFireTimeUtcbehavior for misfired triggers may not align with the new optional column supportWhat this PR changes
MisfireOriginalFireTimeto the sharedQuartzTriggermodel.MISFIRE_ORIG_FIRE_TIME(bigint)misfire_orig_fire_time(bigint)MISFIRE_ORIG_FIRE_TIME(bigint(19))MISFIRE_ORIG_FIRE_TIME(bigint)Scope / compatibility
Validation