Use React Native's prebuilt iOS core in the example instead of patching it - #28
Merged
Merged
Conversation
The example and CI now use the prebuilt React Native core instead of compiling it from source for the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The example no longer carries
patches/react-native@0.88.0-rc.1.patch, and the example and CI now build with React Native's prebuilt iOS core. Clean iOS builds of the example drop from 220 s to 24 s locally.The patch backported the event-beat change from react/react-native#58530. React Native's precompiled binaries don't include a source patch, so the Podfile and the CI iOS job set
RCT_USE_PREBUILT_RNCORE=0and every example build compiled React Native core from source. Same-frame delivery of the first iOS event is a React Native issue that #58530 fixes upstream (merged to RNmain, not in 0.88).platforms.mdkeeps its note about this, anddocs/workflow.mdnow says in one line how to apply the upstream change by hand for testing.patchedDependenciesentry. The lockfile drops thepatch_hashsuffixes.RCT_USE_PREBUILT_RNCORE=0from the Podfile, and bothRCT_*env vars from the CI iOS job. React Native 0.88 defaults both to1(react_native_pods.rb).example/ios/Podfile.lock. The React pods now depend onReact-Core-prebuilt.docs/workflow.mdandwebsite/docs/example.md. The Pending/Ready note from the latter now sits under "Measurement status". Also removed the link fromplatforms.mdto that section.Test plan
Local, Apple M4, Xcode 26.6. The build ran the CI command (
xcodebuild ... -destination 'generic/platform=iOS Simulator' -derivedDataPath build) after a cleanpod installandrm -rf build:main(patched RN core built from source)The CI
iosjob drops from 16m08s onmain(run), wherexcodebuildtook 14 min, to 5m05s on this PR (run), wherexcodebuildtook 2m29s.pnpm install --frozen-lockfileand a cleanbundle exec pod install(Ruby 3.4.8) leave the tree unchanged. Pod install logsUsing React Native Core and React Native Dependencies prebuilt versions.stim ioson a Stim-created iPhone 17 simulator (iOS 26.5, Xcode 26.6). The example launches, the Full screen layout showsMeasurement: Readyand "No active reserved regions", andstim logs --errorsis clean../gradlew :app:assembleDebug -PreactNativeArchitectures=arm64-v8asucceeds. Android already used the prebuilt AAR, so the patch never affected it.