Conversation
mahoneyj02
reviewed
Mar 24, 2018
mahoneyj02
left a comment
mahoneyj02
left a comment
Collaborator
There was a problem hiding this comment.
I'll try to check out the last test before our meeting and see if I can figure anything out. Could it relate to the patch at the beginning of the test?
| <% if current_user.id == single.user_id %> | ||
| <% if user_signed_in? && (current_user.id == single.user_id) %> | ||
| <div class="button"> | ||
| <%= link_to "Continue game", game_path(single.id), method: :put, class: 'btn btn-info' %> |
Collaborator
There was a problem hiding this comment.
I'm probably just being dense, but why are we using the method: :put code in here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to the games#update method. The last test is failing, and I just can't seem to fix it. If someone has time to have a look that would be great. We could also just leave it, comment it out and fix it later.
Added a functionality in games/index.html.erb where button changes to 'continue game' instead of 'join game' when the user is trying to join his own game.