Skip to content

207 - Sync EMBER-DANDI with DANDI v1.1.1 - #209

Merged
NEStock merged 5 commits into
apl-setupfrom
207-sync-fork-to-dandi-v111
Oct 30, 2026
Merged

NEStock merged 5 commits into
apl-setupfrom
207-sync-fork-to-dandi-v111

Conversation

@NEStock

@NEStock NEStock commented Oct 29, 2026

Copy link
Copy Markdown
Member

NEStock and others added 5 commits October 27, 2026 11:52
Sync EMBER-DANDI production
* Restrict OAuth2 application registration to admin users

django-oauth-toolkit ships self-service views under /oauth/applications/
that let any logged-in user register, update, and delete their own OAuth2
applications. They were mounted wholesale via include('oauth2_provider.urls'),
so anyone with a GitHub login (approved or not) could register an external
application against the archive.

Mount the toolkit's routes explicitly and swap the application management
views for subclasses that require a staff or superuser account, matching
the IsAdminUser permission and the dashboard's access rule. The authorize,
token, OIDC, and per-user authorized-token routes are unchanged, and a test
guards that the mounted routes still match the toolkit's own URL table.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QjLAXtUVFgvsAux5X3K5v

* Don't mount oauth applications views

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com>
* Add e2e tests for the table viewer

Eleven Playwright tests over the file browser: which rows link to the viewer
and which keep their own links, opening a table by click and by shared URL,
the header and cell contents, URL cells as links, the raw text view, closing
by button and by the back button, the row and size guardrails, the warning on
an unclosed quoted field, and an embargoed asset going through the API rather
than its S3 URL.

The tests serve the asset listing and the asset's bytes themselves. The
playwright fixture has no tabular asset, and the blob it does have has no
object in storage, since the fixture restores the database and not the bucket;
everything else on the page still comes from the API server.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HifAb4uLDR696kwyXrYQva

* Tighten and extend the table viewer e2e tests (#17)

- The download-button test aborted the download with Playwright's default
  "failed", which makes Chromium commit an error page, so its post-click
  assertions passed whatever the app did.  Abort with "aborted", which
  leaves the page in place, and assert the exact URL.
- Fold the tests that only differ in the file served (truncation, unclosed
  quote) into one parametrized table, adding a .csv with quoted delimiters,
  newlines and escaped quotes, a BOM with CRLF line endings, and a refused
  (403) fetch.
- Parametrize opening/closing: by link + close button, by click + close
  button (previously untested), by click + back button, each also checking
  that no history entry is left behind.
- Check that ?table= naming a non-tabular or missing asset opens nothing.
- Add a search test.
- stubContent() now returns the URLs fetched, replacing the hand-rolled
  routes in the embargo and size-limit tests.

Each new assertion was checked to fail against a deliberately broken
viewer (close by replace, no tabular filter, no @click.stop, CR as row
end, dropped quote escapes).


Claude-Session: https://claude.ai/code/session_01PvaGRZRaAj4zixocHimY24

Co-authored-by: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: GitMate for @yarikoptic <41385986+yarikoptic-gitmate@users.noreply.github.com>
Update sync branch to v1.1.1
@NEStock NEStock self-assigned this Oct 29, 2026
@NEStock NEStock linked an issue Oct 29, 2026 that may be closed by this pull request
10 of 15 tasks
@NEStock
NEStock merged commit b5aabfd into apl-setup Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync Fork to DANDI v1.1.1

5 participants