Repository navigation
207 - Sync EMBER-DANDI with DANDI v1.1.1 - #209
Merged
Merged
Conversation
Sync EMBER-DANDI production
* Restrict OAuth2 application registration to admin users
django-oauth-toolkit ships self-service views under /oauth/applications/
that let any logged-in user register, update, and delete their own OAuth2
applications. They were mounted wholesale via include('oauth2_provider.urls'),
so anyone with a GitHub login (approved or not) could register an external
application against the archive.
Mount the toolkit's routes explicitly and swap the application management
views for subclasses that require a staff or superuser account, matching
the IsAdminUser permission and the dashboard's access rule. The authorize,
token, OIDC, and per-user authorized-token routes are unchanged, and a test
guards that the mounted routes still match the toolkit's own URL table.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QjLAXtUVFgvsAux5X3K5v
* Don't mount oauth applications views
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Jacob Nesbitt <jjnesbitt2@gmail.com>
* Add e2e tests for the table viewer Eleven Playwright tests over the file browser: which rows link to the viewer and which keep their own links, opening a table by click and by shared URL, the header and cell contents, URL cells as links, the raw text view, closing by button and by the back button, the row and size guardrails, the warning on an unclosed quoted field, and an embargoed asset going through the API rather than its S3 URL. The tests serve the asset listing and the asset's bytes themselves. The playwright fixture has no tabular asset, and the blob it does have has no object in storage, since the fixture restores the database and not the bucket; everything else on the page still comes from the API server. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HifAb4uLDR696kwyXrYQva * Tighten and extend the table viewer e2e tests (#17) - The download-button test aborted the download with Playwright's default "failed", which makes Chromium commit an error page, so its post-click assertions passed whatever the app did. Abort with "aborted", which leaves the page in place, and assert the exact URL. - Fold the tests that only differ in the file served (truncation, unclosed quote) into one parametrized table, adding a .csv with quoted delimiters, newlines and escaped quotes, a BOM with CRLF line endings, and a refused (403) fetch. - Parametrize opening/closing: by link + close button, by click + close button (previously untested), by click + back button, each also checking that no history entry is left behind. - Check that ?table= naming a non-tabular or missing asset opens nothing. - Add a search test. - stubContent() now returns the URLs fetched, replacing the hand-rolled routes in the embargo and size-limit tests. Each new assertion was checked to fail against a deliberately broken viewer (close by replace, no tabular filter, no @click.stop, CR as row end, dropped quote escapes). Claude-Session: https://claude.ai/code/session_01PvaGRZRaAj4zixocHimY24 Co-authored-by: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: GitMate for @yarikoptic <41385986+yarikoptic-gitmate@users.noreply.github.com>
Update sync branch to v1.1.1
10 of 15 tasks
sandyhider
approved these changes
Oct 30, 2026
laurendiaz
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update (staging) to https://github.com/dandi/dandi-archive/releases/tag/v1.1.1