Skip to content

refactor(bin/actions) - remove dependency on GitHub from bin #131

Description

@metalwarrior665

Instead, manage it from Actions. First, let's see what configs we actually don't need at all. The rest needs to be passed in.

What we currently use:

Push:

  • repo_url - We could fetch it from the latest Actor version on Apify. - still not 100% clean solution since the repo could change in the future. Another option is to check the current remote origin. Or if these don't match we error and require users to change this in config? Might be easier to pass it in and only keep this as fallback for local dev.
  • commits - We already obtain them from git
  • commit author - We can get it from git
  • branch - This should be the current checked-out branch in git but let's validate

PR:
Doesn't use it, already passes all in args

There is also implicit GITHUB_WORKSPACE env var. We can change the checkout to a default folder where apify-test-tools will look into and allow override. (check AI convo)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    v1: necessaryThis issue must be solved to migrate to v1

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions