Repository navigation
fix: prevent memory leak in stream abort race - #223
Merged
franceccon merged 1 commit intoJul 15, 2026
Merged
Conversation
This update introduces a new `nextWithAbort` function to manage abort signals more effectively during stream reads. The previous implementation of abort handling has been removed to streamline the code and prevent potential issues with long-lived promises. The new approach ensures that the abort listener is properly removed after use, enhancing the overall reliability of the stream processing logic.
franceccon
approved these changes
Jul 15, 2026
franceccon
left a comment
franceccon
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you!
|
noice 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #222
stream.next()call.This prevents promise reactions and decoded message buffers from accumulating on a long-lived pending abort promise.