Fix internal copy/paste losing block styles across documents#125
Merged
Conversation
I had to Move `clips` and `lastCopiedString` from instance to
companion object so clipboard state is shared across the manager
which made it possible to copy styles across internal documents.
When pasting a STYLE block, copy `the attributes
bb:type
utd:overrideStyle
from the clipboard element to the destination block so the source
style is preserved instead of defaulting to Body Text
Caused a crash and learned I had to Skip PAGE_NUM blocks and
UTD-namespace elements because navigating to elements that have no
TextMapElement in the text view
Found another crash when I was getting ready to commit and the context menu rebuild is run on a blank document after paste. it was caused by an empty map list but I only got this because of my debug messages but I fixed it anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to Move
clipsandlastCopiedStringfrom instance tocompanion object so clipboard state is shared across the manager
which made it possible to copy styles across internal documents.
When pasting a STYLE block, copy `the attributes
bb:type
utd:overrideStyle
from the clipboard element to the destination block so the source
style is preserved instead of defaulting to Body Text
Caused a crash and learned I had to Skip PAGE_NUM blocks and
UTD-namespace elements because navigating to elements that have no
TextMapElement in the text view
Found another crash when I was getting ready to commit and the context menu rebuild is run on a blank document after paste. it was caused by an empty map list but I only got this because of my debug messages but I fixed it anyway.