Repository navigation
test: cover multiline string line endings - #166
Merged
kjonescertinia merged 1 commit intoOct 1, 2026
Merged
Conversation
nawforce
marked this pull request as ready for review
October 1, 2026 21:32
kjonescertinia
approved these changes
Oct 1, 2026
kjonescertinia
deleted the
ao/apex-parser-2/issue-158-multiline-line-endings
branch
October 1, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiline string literals already accept LF, CRLF, and bare CR openings. Add matching Java and TypeScript lexer/parser regressions to lock in recognition and exact raw token/body preservation, including the leading newline and escape text.
Assert the literal's start position and following tokens' line/column positions both on the closing line and after another CRLF. Document deliberate CRLF acceptance next to the existing lexer rule. The grammar behavior is unchanged; runtime newline stripping remains out of scope.
Validation:
npm run buildpasses (147 TypeScript tests, 146 Java tests, bundle/type generation and JVM packaging); Prettier andgit diff --checkpass.SAMPLES=/Users/kevinjones/adt/apex-samples npm run systestpasses against v1.4.0 (100 tests and 100 snapshots).GitHub Build CI passes, including the system sample suite.
Closes #158.