Repository navigation
feat!: show the username first in USER_INFO text - #141
Merged
Merged
Conversation
The text is now "<username> : <userId>", not "<userId> <username>". A reader looks for the username; the id is a lookup key.
lcottercertinia
approved these changes
Oct 16, 2026
lcottercertinia
approved these changes
Oct 16, 2026
Merging this PR will improve performance by 11.67%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | parse_19kb |
212 KB | 189.8 KB | +11.67% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing feat/user-info-text (40e5f5d) with main (55427c4)
lcottercertinia
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Overview
The
USER_INFOevent text was005000000000AAA user@example.com. The id came first, but a reader looks for the username.The text is now
user@example.com : 005000000000AAA. A line with no username still gives the id alone.🛠️ Changes
USER_INFOtext putsusernamebeforeuserId— the username is what a reader scans for; the id is a lookup key.' : ', not a space — it matches the other catalog text rules.🧩 Type of change
🔗 Related issues
N/A
✅ Checklist
pnpm run cipasses locallypnpm changeset) if this affects the published package