Skip to content

feat!: show the username first in USER_INFO text - #141

Merged
lcottercertinia merged 2 commits into
mainfrom
feat/user-info-text
Oct 16, 2026
Merged

lcottercertinia merged 2 commits into
mainfrom
feat/user-info-text

Conversation

@lukecotter

Copy link
Copy Markdown
Collaborator

📝 Overview

The USER_INFO event text was 005000000000AAA user@example.com. The id came first, but a reader looks for the username.

The text is now user@example.com : 005000000000AAA. A line with no username still gives the id alone.

🛠️ Changes

  • USER_INFO text puts username before userId — the username is what a reader scans for; the id is a lookup key.
  • The separator is ' : ', not a space — it matches the other catalog text rules.
  • A test asserts the full text — before, no test checked it.

🧩 Type of change

  • 🐛 Bug fix — fixes an issue
  • ✨ Feature — adds new functionality
  • ♻️ Refactor — no behaviour change
  • ⚡ Performance
  • 📝 Docs
  • 🔧 Chore — tooling, CI, deps
  • 💥 Breaking change

🔗 Related issues

N/A

✅ Checklist

  • Tests added/updated
  • pnpm run ci passes locally
  • Changeset added (pnpm changeset) if this affects the published package
  • Docs updated if behaviour or the public API changed

The text is now "<username> : <userId>", not "<userId> <username>". A reader looks for the username; the id is a lookup key.
@codspeed

codspeed Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 11.67%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 5 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Memory parse_19kb 212 KB 189.8 KB +11.67%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing feat/user-info-text (40e5f5d) with main (55427c4)

Open in CodSpeed

@lcottercertinia
lcottercertinia merged commit 53e852e into main Oct 16, 2026
14 of 18 checks passed
@lcottercertinia
lcottercertinia deleted the feat/user-info-text branch October 16, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants