Skip to content

feat: state flowType in the details of FLOW_START_INTERVIEWS_BEGIN - #140

Merged
lcottercertinia merged 1 commit into
mainfrom
feat/flow-type
Oct 16, 2026
Merged

lcottercertinia merged 1 commit into
mainfrom
feat/flow-type

Conversation

@lukecotter

@lukecotter lukecotter commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

📝 Overview

suffix was removed from v1. It told Flow and Process Builder apart for FLOW_START_INTERVIEWS_BEGIN, and a caller now has to climb to the code unit to get that. This adds the answer back, on the event.

🛠️ Changes

  • Add details.flowType to FLOW_START_INTERVIEWS_BEGIN: 'flow' | 'processBuilder' | null.
  • The log line states none of it, so it is read from the code unit above the interviews:
    • Flow unit, or interviews inside other interviews: 'flow'.
    • Workflow unit: 'processBuilder'.
    • Any other unit, or none: null. The old suffix said Process Builder for any unit that was not Flow.
  • Add tests for each case.

🧩 Type of change

  • 🐛 Bug fix — fixes an issue
  • ✨ Feature — adds new functionality
  • ♻️ Refactor — no behaviour change
  • ⚡ Performance
  • 📝 Docs
  • 🔧 Chore — tooling, CI, deps
  • 💥 Breaking change

🔗 Related issues

Follows #139, which removed suffix.

✅ Checklist

  • Tests added/updated
  • pnpm run ci passes locally
  • Changeset added (pnpm changeset) if this affects the published package: not needed, .changeset/v1.md already lists suffix as removed, and flowType is new
  • Docs updated if behaviour or the public API changed

@codspeed

codspeed Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing feat/flow-type (fc142db) with main (d9d3abb)

Open in CodSpeed

Flow and Process Builder are different tools, and the old suffix told them
apart. The log line does not state which one started the interviews, so the
type is read from the code unit above them: Flow is flow, Workflow is
processBuilder, anything else is null.
@lcottercertinia
lcottercertinia merged commit 55427c4 into main Oct 16, 2026
10 checks passed
@lcottercertinia
lcottercertinia deleted the feat/flow-type branch October 16, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants