Repository navigation
ci(bench): add manual walltime runs on a CodSpeed macro runner - #130
Merged
Merged
Conversation
Run the benchmarks in memory mode next to simulation mode on each pull request. Add a walltime job on a CodSpeed macro runner that runs only on manual dispatch, because macro runner minutes are billed.
Memory mode tracks malloc, not the V8 heap, so it shows none of today's parser's objects. The v1 parser keeps its store in typed arrays, which it does track, so the mode moves to that pull request.
lukecotter
changed the title
lcottercertinia
approved these changes
Oct 10, 2026
lukecotter
added a commit
that referenced
this pull request
Oct 10, 2026
Resolve the bench files for v1: parse.bench.ts builds with the engine under the parse_<size> names, and large.ts keeps the heap gate. Rename the logs in legacy-v0.3.json so --baseline matches them. Turn CodSpeed memory mode back on: v1's store is in typed arrays, which it tracks.
lukecotter
added a commit
that referenced
this pull request
Oct 10, 2026
lukecotter
added a commit
that referenced
this pull request
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Overview
CodSpeed runs in simulation mode only. It counts instructions with V8's
--no-opt, so CI never measures TurboFan-optimised code, and its figures do not match local wall time.This adds a walltime job on a CodSpeed macro runner: real time, with the full JIT. It runs only on manual dispatch. Pull requests keep simulation mode as the gate.
🛠️ Changes
walltimejob onworkflow_dispatchonly — macro runner minutes are billed (600 a month on the free plan), and a pull request would run fork code on the runner.codspeed-macro-x64-ryzen-9950x-ubuntu-24-04— wall time on a shared runner is too noisy.Before the first walltime run, an org admin must allow public repositories in the macro runner group. Without that, the job queues until it times out.
Memory mode was tried here and removed. It tracks
malloc, not the V8 heap, so it shows none of today's parser's objects. It moves to #125, where the v1 parser keeps its store in typed arrays that memory mode does track.🧩 Type of change
🔗 Related issues
N/A
✅ Checklist
pnpm run cipasses locallypnpm changeset) if this affects the published package