Skip to content

fix(commits): accept ! breaking-change marker in subject #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apermo merged 2 commits into from
May 1, 2026
Merged

fix(commits): accept ! breaking-change marker in subject #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ec8bc
fix(commits): accept ! breaking-change marker in subject
apermo May 1, 2026
e50c9a9
docs: clarify 0.6.1 CHANGELOG wording
apermo May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable-conventional-commits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
continue
fi

if ! echo "$MSG" | grep -qP "^(${ALLOWED_TYPES})(\(.+\))?: .{1,}$"; then
if ! echo "$MSG" | grep -qP "^(${ALLOWED_TYPES})(\(.+\))?!?: .{1,}$"; then
echo "::error::Invalid commit message: $MSG ($HASH)"
FAILED=1
fi
Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.6.1] - 2026-05-01

### Fixed

- `reusable-conventional-commits.yml` — accept the `!` breaking-change marker in commit subjects
Comment thread
apermo marked this conversation as resolved.
(e.g. `feat(api)!: drop deprecated input`). The Conventional Commits 1.0 spec defines `!` and a
`BREAKING CHANGE:` footer as equivalent ways to mark a breaking change; the validator regex
previously only accepted the footer form, rejecting spec-compliant subjects like the one
intended for the 0.6.0 release commit (which had to be rewritten to drop the `!`).

## [0.6.0] - 2026-05-01

### Changed
Expand Down
Loading