fix(wp-env): drop Composer 2.8 audit workaround#30
Conversation
The docker-config.js sed-patch added in 0.4.1-0.4.3 is no longer needed. FriendsOfPHP/security-advisories#762 (merged 2026-04-18) corrected the PHPUnit advisory metadata Composer consults, so resolution of PHPUnit 11 succeeds again without the override. Matches the upstream revert in WordPress/gutenberg#77472.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up the CI configuration by removing a temporary workaround previously implemented to bypass Composer 2.8 security audit blocks. With the underlying upstream security advisory metadata now corrected, the workaround is obsolete and has been safely reverted across all affected workflow files. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The patch was applied to bypass the gate, / But now the upstream has fixed the state. / The workaround fades, the code is now clean, / The smoothest CI that we've ever seen. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md for version 0.5.1, documenting the removal of a workaround for PHPUnit 11 resolution. However, the workflow files mentioned in the changelog are missing from the current diff, suggesting an incomplete submission. Additionally, the changelog entry requires formatting corrections to address an excessively long line and a missing blank line after the category header.
|
@gemini-code-assist the workflow file changes are present in this PR — see commit 7302a06 which removes the |
|
Thank you for the clarification, @apermo. You are absolutely correct—my initial summary was limited by the default configuration patterns, which caused the workflow files to be excluded from my analysis. I appreciate you pointing that out, and it is good to see that the cleanup has been handled correctly across those files and that the changelog formatting now adheres to the 120-character limit. |
|
Released as v0.5.1 |
Summary
docker-config.jssed-patch fromreusable-wp-e2e.yml,reusable-wp-visual-regression.yml, andreusable-lhci.yml.Why
The workaround shipped in 0.4.1–0.4.3 bypassed Composer 2.8's
audit.block-insecurefilter so wp-env'stests-cliimage could install PHPUnit 11 duringwp-env start.Root cause was a mis-scoped advisory (GHSA-qrr6-mg7r-m243) that flagged the full PHPUnit version range when only 12.5.21 and 13.1.5 are actually vulnerable. Sebastian Bergmann corrected the metadata in the Packagist-facing feed via FriendsOfPHP/security-advisories#762, merged 2026-04-18. That feed takes precedence over GHSA for Composer, so resolution of PHPUnit 11 works again without the override.
Gutenberg closed the parallel upstream PR WordPress/gutenberg#77472 for the same reason (thanks to @swissspidy for the heads-up).
Test plan
actionlintclean on the three modified workflows (pre-existing info warnings only).reusable-wp-e2e,reusable-wp-visual-regression, andreusable-lhcijobs in PR CI go green — these call the reusables via relative path, so PR CI is the integration test.