Extend CSP with support for script-src-attr, style-src-attr #1341
+67
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keesvandieren
changed the title
martin-g
approved these changes
Jan 2, 2026
Member
martin-g
left a comment
martin-g
left a comment
There was a problem hiding this comment.
We need a JIRA ticket for the changelog.
| } | ||
|
|
||
| @Test | ||
| void scriptSrcAttrAndStyleSrcAttributesOnlySupportNoneAndUnsafeInline() { |
Member
There was a problem hiding this comment.
This test could be improved by iterating over all values of CSPDirectiveSrcValue and depending on the value assert that it either throws or passes. I.e. only NONE and UNSAFE_INLINE should pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those new directives have been added to CSP in 2022 but are not yet available in Wicket