chore: use Java 17 for style checks - #2782
Open
wForget wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2782 +/- ##
============================================
+ Coverage 51.02% 51.76% +0.73%
- Complexity 3347 3966 +619
============================================
Files 533 600 +67
Lines 26003 33233 +7230
Branches 2379 3142 +763
============================================
+ Hits 13269 17203 +3934
- Misses 11870 14916 +3046
- Partials 864 1114 +250 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wForget
commented
Aug 18, 2026
| <Bug pattern="NM_METHOD_NAMING_CONVENTION"/> | ||
| <Class name="org.apache.spark.ShuffleType"/> | ||
| </Match> | ||
| <Match> |
Member
Author
There was a problem hiding this comment.
Fix error with ./mvnw -B -fae test-compile spotbugs:check -Pspark4:
[INFO] --- spotbugs:4.7.0.0:check (default-cli) @ rss-client-spark-ui ---
[INFO] BugInstance size is 4
[INFO] Error size is 0
[INFO] Total bugs: 4
[ERROR] Medium: The method name org.apache.spark.UniffleDriverPlugin.LogStringContext(StringContext) doesn't start with a lower case letter [org.apache.spark.UniffleDriverPlugin] At UnifflePlugin.scala:[line 36] NM_METHOD_NAMING_CONVENTION
[ERROR] Medium: The method name org.apache.spark.UniffleListener.LogStringContext(StringContext) doesn't start with a lower case letter [org.apache.spark.UniffleListener] At UniffleListener.scala:[line 31] NM_METHOD_NAMING_CONVENTION
[ERROR] Medium: The method name org.apache.spark.ui.ShufflePage.LogStringContext(StringContext) doesn't start with a lower case letter [org.apache.spark.ui.ShufflePage] At ShufflePage.scala:[line 29] NM_METHOD_NAMING_CONVENTION
[ERROR] Medium: The method name org.apache.spark.ui.ShuffleTab.LogStringContext(StringContext) doesn't start with a lower case letter [org.apache.spark.ui.ShuffleTab] At ShuffleTab.scala:[line 23] NM_METHOD_NAMING_CONVENTION
[INFO]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
The reusable sequential workflow only runs Spark 4.x profiles when using Java 17. Previously, these code quality checks used the default Java 8 configuration, so Spark 4.x modules were not covered.
Does this PR introduce any user-facing change?
No.
How was this patch tested?