[#2780] fix(client): Fix prefetch executor thread leaks - #2781
Merged
Conversation
Member
Author
|
@zuston Could you please take a look? |
zuston
approved these changes
Aug 17, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the prefetch executor thread leak in client read handlers.
The following changes are included:
Invoke
super.close()inHadoopShuffleReadHandler.close()to shut down the executor owned byPrefetchableClientReadHandler.Implement
MultiReplicaClientReadHandler.close()to close all underlying replica read handlers.Initialize
prefetchExecutorswith a named daemon thread factory:The generated thread names follow the
PrefetchableClientReadHandler-%dformat.Why are the changes needed?
When prefetch is enabled, each
PrefetchableClientReadHandlercreates a dedicated executor.HadoopShuffleReadHandleroverridesclose()without invoking the parent implementation. In addition,MultiReplicaClientReadHandlerdoes not propagateclose()to its underlying handlers. Consequently, the prefetch executors may remain active after shuffle reading finishes.Under sustained workloads, the leaked threads can exhaust the process's native-thread resources and cause the following error:
Closing the complete handler hierarchy ensures that the executors are shut down correctly. Using named daemon threads also improves thread identification and prevents prefetch threads from keeping the JVM alive.
Does this PR introduce any user-facing changes?
No.
How was this patch tested?